[Bug]: Review Swedish localization and macOS bundle handling from PR #848

Open
#970 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 6 days

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
c

Research direction

Review PR #848, which contains the implementation for the Swedish GUI and Qt catalogs and localization handling in the nested VirtualBoxVM.app bundle. Start by checking the catalog changes and their placeholder validation with makeallnls and lrelease, then inspect how the PR adds .lproj directories to the nested bundle to match the outer Manager app. Done means the review findings are resolved and the PR is ready to merge.

Written by the indexing model from the issue text.

Description

Summary

The Swedish VirtualBox GUI catalog and the macOS bundle localization handling need review.

Pull request #848 provides the implementation:

  • completes the Swedish GUI and Qt catalogs against the current source set;
  • preserves Qt placeholders and validates the catalog with makeallnls and lrelease;
  • adds the missing .lproj directories to the nested VirtualBoxVM.app bundle, matching the handling already used by the outer Manager app.

The macOS localization part addresses the nested VM bundle specifically. The official Apple Silicon package contains Swedish QM catalogs, but its nested VM app has no language-specific .lproj directories.

Please review and consider merging PR #848.

Dominant language
C
Stars
1.4k
Forks
219
PR merge metrics
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from VirtualBox/virtualbox

All issues in VirtualBox/virtualbox

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.