[Bug]: Guest Additions 7.2.20 vboxvideo fails to build on Linux kernel 6.12.113 (drm_fb_helper_restore_fbdev_mode_unlocked: too few arguments)

Open Beginner friendly
#918 9 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 6 days

@Berbe is already working on this.

Since Nov 3, 2026.

  • #955 by @Berbe — open

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
76/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
c, linux

Research direction

The failure is in src/vboxguest-7.2.20/vboxvideo/vbox_main.c, in vbox_driver_lastclose; start by checking the kernel version guards used for the related fix in issue #845. Reproduce the module build against Debian's 6.12.113 headers and confirm the version guard handles the added argument while retaining compatibility with earlier kernels; done means vboxvideo builds successfully for both kernel API variants.

Written by the indexing model from the issue text.

Description

bug
Version

7.2.20

Host OS Type

Windows

Host OS name + version

Windows 11

Host Architecture

x86

Guest OS Type

Linux

Guest Architecture

x86

Guest OS name + version

Debian 13 - Linux kernel 6.12.113

Component

Guest Additions/Installer

What happened?

After upgrading a Debian 13 guest to kernel 6.12.113+deb13-amd64, the
Guest Additions 7.2.20 kernel modules no longer build. vboxguest and
vboxsf build without errors; vboxvideo fails:

/tmp/vbox.0/vbox_main.c: In function 'vbox_driver_lastclose':
/tmp/vbox.0/vbox_main.c:562:17: error: too few arguments to function 'drm_fb_helper_restore_fbdev_mode_unlocked'
562 | drm_fb_helper_restore_fbdev_mode_unlocked(&vbox->fbdev->helper);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /tmp/vbox.0/vbox_drv.h:166,
from /tmp/vbox.0/vbox_main.c:31:
/usr/src/linux-headers-6.12.113+deb13-common/include/drm/drm_fb_helper.h:247:5: note: declared here
247 | int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper fb_helper,
make
** [.../scripts/Makefile.build:234: /tmp/vbox.0/vbox_main.o] Error 1
make: *** [/tmp/vbox.0/Makefile-footer.gmk:146: vboxvideo] Error 2

The DRM helper drm_fb_helper_restore_fbdev_mode_unlocked() gained a
second argument (bool force) in a 6.12.y stable update, now shipped by
Debian. The previous Debian kernel (<6.12.xx+deb13-amd64>) built the
module without errors.

This is the same class of problem as #845 (drm_fb_helper_alloc_info
change in 6.12.107, fixed in 7.2.20): a DRM API change backported into
the 6.12 stable series, so a check on the mainline version alone is not
enough.

Workaround / proposed fix (tested locally, module builds and loads):
in src/vboxguest-7.2.20/vboxvideo/vbox_main.c, pass the new argument:

  • drm_fb_helper_restore_fbdev_mode_unlocked(&vbox->fbdev->helper);
  • drm_fb_helper_restore_fbdev_mode_unlocked(&vbox->fbdev->helper, false);

This should be guarded by a kernel version check covering
6.12.113+ (and whichever mainline version introduced the change),
similar to the fix for #845.

vboxadd-setup.log

How can we reproduce this?
  1. Debian 13 amd64 guest with Guest Additions 7.2.20 installed from the
    Oracle ISO (VBoxLinuxAdditions.run).
  2. apt update && apt upgrade to linux-image-6.12.113+deb13-amd64 and
    linux-headers-6.12.113+deb13-amd64.
  3. Run /sbin/rcvboxadd setup (or reboot).
  4. Check /var/log/vboxadd-setup.log: the vboxvideo build fails as above.
Did you upload all of your necessary log files, screenshots, etc.?
  • Yes, I've uploaded all pertinent files to this issue.
Dominant language
C
Stars
1.4k
Forks
219
PR merge metrics
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from VirtualBox/virtualbox

All issues in VirtualBox/virtualbox

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.