[Bug]: Guest Additions 7.2.20 vboxvideo fails to build on Linux kernel 6.12.113 (drm_fb_helper_restore_fbdev_mode_unlocked: too few arguments)
Maintainers usually reply within 6 days
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- c, linux
- Domain
- devtools, operating-systems
Research direction
The failure is in src/vboxguest-7.2.20/vboxvideo/vbox_main.c, in vbox_driver_lastclose; start by checking the kernel version guards used for the related fix in issue #845. Reproduce the module build against Debian's 6.12.113 headers and confirm the version guard handles the added argument while retaining compatibility with earlier kernels; done means vboxvideo builds successfully for both kernel API variants.
Written by the indexing model from the issue text.
Description
Version
7.2.20
Host OS Type
Windows
Host OS name + version
Windows 11
Host Architecture
x86
Guest OS Type
Linux
Guest Architecture
x86
Guest OS name + version
Debian 13 - Linux kernel 6.12.113
Component
Guest Additions/Installer
What happened?
After upgrading a Debian 13 guest to kernel 6.12.113+deb13-amd64, the
Guest Additions 7.2.20 kernel modules no longer build. vboxguest and
vboxsf build without errors; vboxvideo fails:
/tmp/vbox.0/vbox_main.c: In function 'vbox_driver_lastclose':
/tmp/vbox.0/vbox_main.c:562:17: error: too few arguments to function 'drm_fb_helper_restore_fbdev_mode_unlocked'
562 | drm_fb_helper_restore_fbdev_mode_unlocked(&vbox->fbdev->helper);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /tmp/vbox.0/vbox_drv.h:166,
from /tmp/vbox.0/vbox_main.c:31:
/usr/src/linux-headers-6.12.113+deb13-common/include/drm/drm_fb_helper.h:247:5: note: declared here
247 | int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper fb_helper,
make** [.../scripts/Makefile.build:234: /tmp/vbox.0/vbox_main.o] Error 1
make: *** [/tmp/vbox.0/Makefile-footer.gmk:146: vboxvideo] Error 2
The DRM helper drm_fb_helper_restore_fbdev_mode_unlocked() gained a
second argument (bool force) in a 6.12.y stable update, now shipped by
Debian. The previous Debian kernel (<6.12.xx+deb13-amd64>) built the
module without errors.
This is the same class of problem as #845 (drm_fb_helper_alloc_info
change in 6.12.107, fixed in 7.2.20): a DRM API change backported into
the 6.12 stable series, so a check on the mainline version alone is not
enough.
Workaround / proposed fix (tested locally, module builds and loads):
in src/vboxguest-7.2.20/vboxvideo/vbox_main.c, pass the new argument:
- drm_fb_helper_restore_fbdev_mode_unlocked(&vbox->fbdev->helper);
- drm_fb_helper_restore_fbdev_mode_unlocked(&vbox->fbdev->helper, false);
This should be guarded by a kernel version check covering
6.12.113+ (and whichever mainline version introduced the change),
similar to the fix for #845.
How can we reproduce this?
- Debian 13 amd64 guest with Guest Additions 7.2.20 installed from the
Oracle ISO (VBoxLinuxAdditions.run). - apt update && apt upgrade to linux-image-6.12.113+deb13-amd64 and
linux-headers-6.12.113+deb13-amd64. - Run /sbin/rcvboxadd setup (or reboot).
- Check /var/log/vboxadd-setup.log: the vboxvideo build fails as above.
Did you upload all of your necessary log files, screenshots, etc.?
- Yes, I've uploaded all pertinent files to this issue.
- Dominant language
- C
- Stars
- 1.4k
- Forks
- 219
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from VirtualBox/virtualbox
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 84/100
VirtualBox/virtualbox#996 ·
Maintainers usually reply within 6 days
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
VirtualBox/virtualbox#979 ·
Maintainers usually reply within 6 days
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 25/100
VirtualBox/virtualbox#995 ·
Maintainers usually reply within 6 days
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 45/100
VirtualBox/virtualbox#994 ·
Maintainers usually reply within 6 days
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 30/100
VirtualBox/virtualbox#993 ·
Maintainers usually reply within 6 days
All issues in VirtualBox/virtualbox
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
ESPresense/ESPresense#2680 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
ImageMagick/ImageMagick#9134 ·
Maintainers usually reply within 1 day
-
Builder: a structure opened without calculation data shows the Diffraction (fibre) view by defaultOpenbug
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
FriendsofECCE/ECCE#1245 · 1 comment ·
-
Arch: ARM/AArch64 Doc
Difficulty 1/5 Under an hour Newbie friendliness 90/100
RT-Thread/rt-thread#12082 · 1 comment ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
apache/nuttx-apps#4108 · 4 comments ·
Maintainers usually reply within 1 day