Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

Evoker: Diverted Power chance is ~5.5% per Bombardment in game (SimC uses a guessed 10%)

已关闭 适合新手
#11,978 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
70/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
cpp
领域
game-dev

调研方向

在 engine/class_modules/sc_evoker.cpp 中,检查 bombardments_damage_t 以及引用行附近的 diverted_power_chance 调用。首先阅读周围的 Scalecommander 天赋逻辑,并检查附近的 proc 概率如何表示;将报告的日志作为起始证据。完成标准是该概率反映测得的触发率,并且相关的模拟行为已得到验证。

由索引模型根据 Issue 内容生成。

描述

Evoker (Scalecommander): Diverted Power's Essence Burst chance is ~5.5% per Bombardment in game, SimC uses a guessed 10%

bombardments_damage_t rolls diverted_power_chance( 0.1 ) on every Bombardments execute, commented "Reasonable guess. TODO: Get more accurate" (engine/class_modules/sc_evoker.cpp, around lines 8229 and 8326 at c5fea93fb77d).

Measured on Warcraft Logs event streams of Mythic+ keys played on 12.1.5 (live, US and EU):

  • Devastation Evokers with Diverted Power talented (talent entry 120124 in combatantinfo talentTree): 1,148 player-runs.
  • One Bombardment = the player's 434481 damage events at a single timestamp (one execute, split over targets): 501,759 Bombardments.
  • A proc = an Essence Burst (359618) gain on the player 0–10 ms after the Bombardment.
  • To avoid missing procs that land while Essence Burst is already at max stacks, the rate is taken on Bombardments that land while Essence Burst is down, so a proc must log an applybuff: 21,872 / 399,931 = 5.47% (95% bootstrap over players 5.38–5.57%).
  • On all Bombardments, any Essence Burst gain: 5.10%.
  • Control (the same 10 ms window 777 ms later, catching Essence Burst from any other source): 0.08%.

So the in-game chance looks like ~5.5%, about half of the 10% in the module. A change to diverted_power_chance( 0.055 ) (or a value you derive yourself) would bring Scalecommander's Essence Burst rate in line.

Happy to share the counting script if useful.

主要语言
C++
星标
1.6k
派生
789
平均合并
9 小时 46 分钟
30 天内合并 PR
55

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

simulationcraft/simc 的其他 Issue

查看 simulationcraft/simc 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。