Integration tests import tool modules inside tests and can time out under load
维护者通常 1 天内回复
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 25/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 停滞
- 技术栈
- typescript
- 领域
- testing
调研方向
Read mcp-server/src/tools/__tests__/integration.test.ts, especially the dynamic imports and mock setup at the cited lines. Run the integration tests with cd mcp-server && npm test to observe the timeout and mock leakage. The acceptance criteria are to remove dynamic imports from test bodies and reset mocks between tests; linked pull request #175 is already open.
由索引模型根据 Issue 内容生成。
描述
Summary
The healthCheck integration tests import the tool module inside the test body, so a cold import can exceed Vitest's 5 s default timeout under a full parallel run. The timed-out test then leaves a queued mock value behind and the next test fails too.
Where
mcp-server/src/tools/__tests__/integration.test.ts:42-77(await import("../healthCheck.js")insideit)mcp-server/src/tools/__tests__/integration.test.ts:37-39(vi.clearAllMocks()keepsmockResolvedValueOncequeues)
Details
Seen once in a full npx vitest run on Windows:
× returns pass/fail checklist from a single round trip 5858ms (Test timed out in 5000ms)
× passes node parameter to execSSH (expected undefined to be 'nas')
The same file passed alone, and three immediate full reruns passed. The second failure is a cascade: the first test's handler finished after its timeout and consumed the next test's mock, or its queued value was left behind.
Impact
Occasional red CI or release-gate runs that pass on retry, which hides real failures over time.
Suggested fix
- Import the tool modules at the top of the file (static imports) instead of inside each test.
- Reset mock state between tests with
vi.resetAllMocks()(ormockResetinafterEach) so a timed-out test cannot leak queued values.
Acceptance criteria
- No dynamic imports inside test bodies in integration.test.ts
- Mocks are reset between tests
Related: #164
Getting started
- Relevant files:
mcp-server/src/tools/__tests__/integration.test.ts - How to run tests:
cd mcp-server && npm ci && npm test
Filed by repo-audit/fix-issues at 4c8499a. Severity: low. Effort: S. audit-key: testing|mcp-server/src/tools/__tests__/integration.test.ts|dynamic-import-timeout
- 主要语言
- TypeScript
- 星标
- 0
- 派生
- 4
- 平均合并
- 10 小时 16 分钟
- 30 天内合并 PR
- 2
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
TMHSDigital/Home-Lab-Developer-Tools 的其他 Issue
-
speedtestResults ignores count: /api/speedtest/latest returns one result可能已有人在做 @laozhej 于 2 天前认领。 未关闭bug severity: low
难度 2/5 1-3 小时 新手友好度 80/100
TMHSDigital/Home-Lab-Developer-Tools#160 ·
维护者通常 1 天内回复
-
Grafana dashboard import to complete the export/import round trip可能已有人在做 @laozhej 今天认领。 未关闭enhancement severity: low
难度 3/5 1-2 天 新手友好度 68/100
TMHSDigital/Home-Lab-Developer-Tools#171 ·
维护者通常 1 天内回复
-
help wanted severity: low testing
难度 4/5 3-5 天 新手友好度 55/100
TMHSDigital/Home-Lab-Developer-Tools#164 · 1 条评论 ·
维护者通常 1 天内回复
-
enhancement severity: medium
难度 3/5 1-2 天 新手友好度 72/100
TMHSDigital/Home-Lab-Developer-Tools#159 ·
维护者通常 1 天内回复
-
Add AdGuard local DNS rewrite tools (list, add, delete)可能已有人在做 @laozhej 于 1 天前认领。 未关闭enhancement severity: medium
难度 3/5 1-2 天 新手友好度 72/100
TMHSDigital/Home-Lab-Developer-Tools#157 ·
维护者通常 1 天内回复
查看 TMHSDigital/Home-Lab-Developer-Tools 的全部 Issue
相似的 Issue
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)未关闭
难度 2/5 1-3 小时 新手友好度 62/100
microsoft/playwright#44289 ·
维护者通常 1 天内回复
-
good first issue
难度 2/5 半天 新手友好度 65/100
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 72/100
blamechris/chroxy#9272 ·
维护者通常 1 天内回复
-
no-repo-link tool-submission
难度 1/5 1 小时以内 新手友好度 66/100
BraveOPotato/NoSignups#2458 ·
-
难度 2/5 1-3 小时 新手友好度 70/100
drmrd/vernacular#1061 ·
维护者通常 1 天内回复