Integration tests import tool modules inside tests and can time out under load

未關閉
#174 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

@laozhej 已經在處理了。

開始於 2026年11月19日。

  • #175 來自 @laozhej —— 未關閉

評估

難度
2/5
預估耗時
1-3 小時
新手友好度
25/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
停滯
技術堆疊
typescript
領域
testing

研究方向

Read mcp-server/src/tools/__tests__/integration.test.ts, especially the dynamic imports and mock setup at the cited lines. Run the integration tests with cd mcp-server && npm test to observe the timeout and mock leakage. The acceptance criteria are to remove dynamic imports from test bodies and reset mocks between tests; linked pull request #175 is already open.

由索引模型根據 Issue 內容生成。

描述

good first issue severity: low testing

Summary

The healthCheck integration tests import the tool module inside the test body, so a cold import can exceed Vitest's 5 s default timeout under a full parallel run. The timed-out test then leaves a queued mock value behind and the next test fails too.

Where

  • mcp-server/src/tools/__tests__/integration.test.ts:42-77 (await import("../healthCheck.js") inside it)
  • mcp-server/src/tools/__tests__/integration.test.ts:37-39 (vi.clearAllMocks() keeps mockResolvedValueOnce queues)

Details

Seen once in a full npx vitest run on Windows:

× returns pass/fail checklist from a single round trip 5858ms   (Test timed out in 5000ms)
× passes node parameter to execSSH                              (expected undefined to be 'nas')

The same file passed alone, and three immediate full reruns passed. The second failure is a cascade: the first test's handler finished after its timeout and consumed the next test's mock, or its queued value was left behind.

Impact

Occasional red CI or release-gate runs that pass on retry, which hides real failures over time.

Suggested fix

  • Import the tool modules at the top of the file (static imports) instead of inside each test.
  • Reset mock state between tests with vi.resetAllMocks() (or mockReset in afterEach) so a timed-out test cannot leak queued values.

Acceptance criteria

  • No dynamic imports inside test bodies in integration.test.ts
  • Mocks are reset between tests

Related: #164

Getting started

  • Relevant files: mcp-server/src/tools/__tests__/integration.test.ts
  • How to run tests: cd mcp-server && npm ci && npm test

Filed by repo-audit/fix-issues at 4c8499a. Severity: low. Effort: S. audit-key: testing|mcp-server/src/tools/__tests__/integration.test.ts|dynamic-import-timeout

主要語言
TypeScript
星號
0
分支
4
平均合併
10 小時 16 分鐘
30 天內合併 PR
2

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

TMHSDigital/Home-Lab-Developer-Tools 的其他 Issue

查看 TMHSDigital/Home-Lab-Developer-Tools 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。