Integration tests import tool modules inside tests and can time out under load
維護者通常 1 天內回覆
評估
- 難度
- 2/5
- 預估耗時
- 1-3 小時
- 新手友好度
- 25/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 停滯
- 技術堆疊
- typescript
- 領域
- testing
研究方向
Read mcp-server/src/tools/__tests__/integration.test.ts, especially the dynamic imports and mock setup at the cited lines. Run the integration tests with cd mcp-server && npm test to observe the timeout and mock leakage. The acceptance criteria are to remove dynamic imports from test bodies and reset mocks between tests; linked pull request #175 is already open.
由索引模型根據 Issue 內容生成。
描述
Summary
The healthCheck integration tests import the tool module inside the test body, so a cold import can exceed Vitest's 5 s default timeout under a full parallel run. The timed-out test then leaves a queued mock value behind and the next test fails too.
Where
mcp-server/src/tools/__tests__/integration.test.ts:42-77(await import("../healthCheck.js")insideit)mcp-server/src/tools/__tests__/integration.test.ts:37-39(vi.clearAllMocks()keepsmockResolvedValueOncequeues)
Details
Seen once in a full npx vitest run on Windows:
× returns pass/fail checklist from a single round trip 5858ms (Test timed out in 5000ms)
× passes node parameter to execSSH (expected undefined to be 'nas')
The same file passed alone, and three immediate full reruns passed. The second failure is a cascade: the first test's handler finished after its timeout and consumed the next test's mock, or its queued value was left behind.
Impact
Occasional red CI or release-gate runs that pass on retry, which hides real failures over time.
Suggested fix
- Import the tool modules at the top of the file (static imports) instead of inside each test.
- Reset mock state between tests with
vi.resetAllMocks()(ormockResetinafterEach) so a timed-out test cannot leak queued values.
Acceptance criteria
- No dynamic imports inside test bodies in integration.test.ts
- Mocks are reset between tests
Related: #164
Getting started
- Relevant files:
mcp-server/src/tools/__tests__/integration.test.ts - How to run tests:
cd mcp-server && npm ci && npm test
Filed by repo-audit/fix-issues at 4c8499a. Severity: low. Effort: S. audit-key: testing|mcp-server/src/tools/__tests__/integration.test.ts|dynamic-import-timeout
- 主要語言
- TypeScript
- 星號
- 0
- 分支
- 4
- 平均合併
- 10 小時 16 分鐘
- 30 天內合併 PR
- 2
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
TMHSDigital/Home-Lab-Developer-Tools 的其他 Issue
-
speedtestResults ignores count: /api/speedtest/latest returns one result可能已有人在做 @laozhej 於 2 天前認領。 未關閉bug severity: low
難度 2/5 1-3 小時 新手友好度 80/100
TMHSDigital/Home-Lab-Developer-Tools#160 ·
維護者通常 1 天內回覆
-
Grafana dashboard import to complete the export/import round trip可能已有人在做 @laozhej 今天認領。 未關閉enhancement severity: low
難度 3/5 1-2 天 新手友好度 68/100
TMHSDigital/Home-Lab-Developer-Tools#171 ·
維護者通常 1 天內回覆
-
help wanted severity: low testing
難度 4/5 3-5 天 新手友好度 55/100
TMHSDigital/Home-Lab-Developer-Tools#164 · 1 則留言 ·
維護者通常 1 天內回覆
-
enhancement severity: medium
難度 3/5 1-2 天 新手友好度 72/100
TMHSDigital/Home-Lab-Developer-Tools#159 ·
維護者通常 1 天內回覆
-
Add AdGuard local DNS rewrite tools (list, add, delete)可能已有人在做 @laozhej 於 1 天前認領。 未關閉enhancement severity: medium
難度 3/5 1-2 天 新手友好度 72/100
TMHSDigital/Home-Lab-Developer-Tools#157 ·
維護者通常 1 天內回覆
查看 TMHSDigital/Home-Lab-Developer-Tools 的全部 Issue
相似的 Issue
-
clawsweeper:needs-maintainer-review clawsweeper:needs-product-decision clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster P3
難度 2/5 1-3 小時 新手友好度 76/100
openclaw/openclaw#203385 · 1 則留言 · 1 個 reaction ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 72/100
nwverse/persona#12800 · 1 則留言 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 80/100
維護者通常 1 天內回覆
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)未關閉
難度 2/5 1-3 小時 新手友好度 62/100
microsoft/playwright#44289 ·
維護者通常 1 天內回覆
-
good first issue
難度 2/5 半天 新手友好度 65/100
維護者通常 1 天內回覆