Integration tests import tool modules inside tests and can time out under load

Aperta
#174 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@laozhej ci sta già lavorando.

Dal 19/11/2026.

  • #175 di @laozhej — aperta

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
25/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
typescript
Ambito
testing

Direzione di ricerca

Read mcp-server/src/tools/__tests__/integration.test.ts, especially the dynamic imports and mock setup at the cited lines. Run the integration tests with cd mcp-server && npm test to observe the timeout and mock leakage. The acceptance criteria are to remove dynamic imports from test bodies and reset mocks between tests; linked pull request #175 is already open.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

good first issue severity: low testing

Summary

The healthCheck integration tests import the tool module inside the test body, so a cold import can exceed Vitest's 5 s default timeout under a full parallel run. The timed-out test then leaves a queued mock value behind and the next test fails too.

Where

  • mcp-server/src/tools/__tests__/integration.test.ts:42-77 (await import("../healthCheck.js") inside it)
  • mcp-server/src/tools/__tests__/integration.test.ts:37-39 (vi.clearAllMocks() keeps mockResolvedValueOnce queues)

Details

Seen once in a full npx vitest run on Windows:

× returns pass/fail checklist from a single round trip 5858ms   (Test timed out in 5000ms)
× passes node parameter to execSSH                              (expected undefined to be 'nas')

The same file passed alone, and three immediate full reruns passed. The second failure is a cascade: the first test's handler finished after its timeout and consumed the next test's mock, or its queued value was left behind.

Impact

Occasional red CI or release-gate runs that pass on retry, which hides real failures over time.

Suggested fix

  • Import the tool modules at the top of the file (static imports) instead of inside each test.
  • Reset mock state between tests with vi.resetAllMocks() (or mockReset in afterEach) so a timed-out test cannot leak queued values.

Acceptance criteria

  • No dynamic imports inside test bodies in integration.test.ts
  • Mocks are reset between tests

Related: #164

Getting started

  • Relevant files: mcp-server/src/tools/__tests__/integration.test.ts
  • How to run tests: cd mcp-server && npm ci && npm test

Filed by repo-audit/fix-issues at 4c8499a. Severity: low. Effort: S. audit-key: testing|mcp-server/src/tools/__tests__/integration.test.ts|dynamic-import-timeout

Lingua principale
TypeScript
Stelle
0
Fork
4
Merge medio
10h 16m
PR unite (30g)
2

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TMHSDigital/Home-Lab-Developer-Tools

Tutte le issue di TMHSDigital/Home-Lab-Developer-Tools

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.