Add AdGuard local DNS rewrite tools (list, add, delete)

未关闭
#157 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@laozhej 已经在做这个了。

开始于 2026年11月20日。

  • #177 来自 @laozhej —— 未关闭

评估

难度
3/5
预计耗时
1-2 天
新手友好度
72/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
活跃
技术栈
typescript

调研方向

Start by reading mcp-server/src/tools/adguardFilterToggle.ts to see how an AdGuard POST is authenticated and wrapped in a confirm gate, then find where tools are registered so the two new ones follow the same shape. Check whether an AdGuard request/response type module already exists before adding new ones, and mirror the existing tool tests under mcp-server (npm test, npm run typecheck). Finish by adding both tools to skills/dns-management/SKILL.md around the cited lines. Done means list returns rewrites, set validates domain/answer and requires confirmation, and the skill documents both.

由索引模型根据 Issue 内容生成。

描述

enhancement severity: medium

Summary

The dns-management skill covers creating local DNS rewrites and cites POST /control/rewrite/add, but no tool lists or changes rewrites.

Where

  • skills/dns-management/SKILL.md:4, :25, :52, :79
  • mcp-server/src/tools/adguardFilterToggle.ts (existing authenticated, confirm-gated AdGuard POST)

Details

service.home.lab -> Pi IP is the most common home-lab DNS task. Today it needs a hand edit or a free-form nodeExec curl.

Impact

The skill's main workflow has no safe tool path.

Suggested fix

Add read-only homelab_adguardRewrites (GET /control/rewrite/list) and confirm-gated homelab_adguardRewriteSet (action: add|delete, domain, answer validated as IP or hostname), reusing the AdGuard auth helper and the filter-toggle request pattern. Add both to the skill.

Acceptance criteria

  • List and set tools registered with correct annotations
  • Set tool confirm-gated with input validation
  • Skill updated

Getting started

  • Relevant files: mcp-server/src/tools/adguardFilterToggle.ts, skills/dns-management/SKILL.md
  • How to run tests: cd mcp-server && npm install && npm test (and npm run typecheck); structure tests: pip install -r requirements-test.txt && pytest tests/ -v
  • Conventions: see CLAUDE.md and CONTRIBUTING.md

Filed by repo-audit/full-audit at 636fefb. Severity: medium. Effort: S. audit-key: enhancement|skills/dns-management/SKILL.md|homelab_adguardRewrites

主要语言
TypeScript
星标
0
派生
4
平均合并
10 小时 16 分钟
30 天内合并 PR
2

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TMHSDigital/Home-Lab-Developer-Tools 的其他 Issue

查看 TMHSDigital/Home-Lab-Developer-Tools 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。