Integration tests import tool modules inside tests and can time out under load

Offen
#174 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@laozhej arbeitet bereits daran.

Seit 19.11.2026.

  • #175 von @laozhej — offen

Bewertung

Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Anfängerfreundlichkeit
25/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Veraltet
Tech-Stack
typescript
Bereich
testing

Rechercherichtung

Read mcp-server/src/tools/__tests__/integration.test.ts, especially the dynamic imports and mock setup at the cited lines. Run the integration tests with cd mcp-server && npm test to observe the timeout and mock leakage. The acceptance criteria are to remove dynamic imports from test bodies and reset mocks between tests; linked pull request #175 is already open.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

good first issue severity: low testing

Summary

The healthCheck integration tests import the tool module inside the test body, so a cold import can exceed Vitest's 5 s default timeout under a full parallel run. The timed-out test then leaves a queued mock value behind and the next test fails too.

Where

  • mcp-server/src/tools/__tests__/integration.test.ts:42-77 (await import("../healthCheck.js") inside it)
  • mcp-server/src/tools/__tests__/integration.test.ts:37-39 (vi.clearAllMocks() keeps mockResolvedValueOnce queues)

Details

Seen once in a full npx vitest run on Windows:

× returns pass/fail checklist from a single round trip 5858ms   (Test timed out in 5000ms)
× passes node parameter to execSSH                              (expected undefined to be 'nas')

The same file passed alone, and three immediate full reruns passed. The second failure is a cascade: the first test's handler finished after its timeout and consumed the next test's mock, or its queued value was left behind.

Impact

Occasional red CI or release-gate runs that pass on retry, which hides real failures over time.

Suggested fix

  • Import the tool modules at the top of the file (static imports) instead of inside each test.
  • Reset mock state between tests with vi.resetAllMocks() (or mockReset in afterEach) so a timed-out test cannot leak queued values.

Acceptance criteria

  • No dynamic imports inside test bodies in integration.test.ts
  • Mocks are reset between tests

Related: #164

Getting started

  • Relevant files: mcp-server/src/tools/__tests__/integration.test.ts
  • How to run tests: cd mcp-server && npm ci && npm test

Filed by repo-audit/fix-issues at 4c8499a. Severity: low. Effort: S. audit-key: testing|mcp-server/src/tools/__tests__/integration.test.ts|dynamic-import-timeout

Vorherrschende Sprache
TypeScript
Sterne
0
Forks
4
Ø Merge
10 Std. 16 Min.
Gemergte PRs (30 T.)
2

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus TMHSDigital/Home-Lab-Developer-Tools

Alle Issues in TMHSDigital/Home-Lab-Developer-Tools

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.