16 tools have no handler test; ssh-api test mocks are copied and have drifted
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 55/100
- Issue 类型
- 重构
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- node.js, typescript
- 领域
- testing
调研方向
Start by reading mcp-server/src/utils/ssh-api.ts around the exported helpers and the checkSSHAvailable reference, then compare it with the hand-written mocks in handlers.test.ts, integration.test.ts and confirm-gates.test.ts. Create one shared mock factory that uses importOriginal() and overrides only execSSH, then migrate one test file at a time and run cd mcp-server && npm install && npm test. Done means every listed tool has at least one handler test, checkSSHAvailable and its mock are gone, and the tests pass against the real helper shapes.
由索引模型根据 Issue 内容生成。
描述
Summary
Sixteen tools have only schema and registration coverage, and each test file hand-writes its own ssh-api mock, which no longer matches the real module.
Where
mcp-server/src/tools/__tests__/handlers.test.ts:3-13, :59-61, :227-241mcp-server/src/tools/__tests__/integration.test.ts:3-28mcp-server/src/tools/__tests__/confirm-gates.test.ts:6-17- mcp-server/src/utils/ssh-api.ts:406-412 (
checkSSHAvailable, unused)
Details
No handler or command test for: adguardQueryLog, aptUpgradable, certList, composePull, containerScan, diskUsage, fail2banStatus, journalLogs, kernelInfo, networkInfo, npmCerts, ntfySend, openPorts, serviceLogs, speedtestResults, ufwStatus. piStatus's node: "all" path is untested.
Mock drift: handlers.test.ts's getNodeConfig returns no port; its nodeSetting ignores per-node env; errorResponse is re-implemented as error.message; TIMEOUTS values are copied; integration still mocks the unused checkSSHAvailable. The fan-out test installs a mockImplementation and resets it only on its last line, so one failed assertion cascades into later tests (vi.clearAllMocks keeps implementations).
Impact
Changes to URLs, token flow, default ports and empty-output messages in these tools would not be caught, and tool tests pass against behavior the real helpers do not have.
Suggested fix
- Add a shared mock helper that spreads
importOriginal()and overrides onlyexecSSH; switch confirm-gates, handlers and integration to it one at a time. - Use
vi.resetAllMocks()(ormockResetinafterEach). - Delete
checkSSHAvailableand its mock. - Handler tests: ntfySend (URL, optional headers, empty-output message, exit 7); certList and npmCerts (login then Bearer GET, non-JSON login); composePull (discovery,
HOMELAB_COMPOSE_FILES,TIMEOUTS.long); piStatusnode: "all"; adguardQueryLog (URL-encodedsearch, defaultlimit=25); serviceLogs and journalLogs (sinceconversion, empty output). - One per-node env test:
HOMELAB_NODES={"nas":{"host":"nas.local","env":{"HOMELAB_ADGUARD_PORT":"3001"}}}uses port 3001 fornode: "nas".
Acceptance criteria
- Every tool has at least one handler test
- Test files share one mock factory based on the real module
Related: #101
Getting started
- Relevant files:
mcp-server/src/tools/__tests__/handlers.test.ts,mcp-server/src/tools/__tests__/integration.test.ts,mcp-server/src/tools/__tests__/confirm-gates.test.ts,mcp-server/src/utils/ssh-api.ts - How to run tests:
cd mcp-server && npm install && npm test(andnpm run typecheck); structure tests:pip install -r requirements-test.txt && pytest tests/ -v - Conventions: see
CLAUDE.mdandCONTRIBUTING.md
Filed by repo-audit/full-audit at 636fefb. Severity: low. Effort: M. audit-key: testing|mcp-server/src/tools|handler-coverage
- 主要语言
- TypeScript
- 星标
- 0
- 派生
- 4
- 平均合并
- 10 小时 16 分钟
- 30 天内合并 PR
- 2
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
TMHSDigital/Home-Lab-Developer-Tools 的其他 Issue
-
speedtestResults ignores count: /api/speedtest/latest returns one result可能已有人在做 @laozhej 于 2 天前认领。 未关闭bug severity: low
难度 2/5 1-3 小时 新手友好度 80/100
TMHSDigital/Home-Lab-Developer-Tools#160 ·
维护者通常 1 天内回复
-
Integration tests import tool modules inside tests and can time out under load可能已有人在做 @laozhej 于 2 天前认领。 未关闭good first issue severity: low testing
难度 2/5 1-3 小时 新手友好度 25/100
TMHSDigital/Home-Lab-Developer-Tools#174 ·
维护者通常 1 天内回复
-
Grafana dashboard import to complete the export/import round trip可能已有人在做 @laozhej 今天认领。 未关闭enhancement severity: low
难度 3/5 1-2 天 新手友好度 68/100
TMHSDigital/Home-Lab-Developer-Tools#171 ·
维护者通常 1 天内回复
-
enhancement severity: medium
难度 3/5 1-2 天 新手友好度 72/100
TMHSDigital/Home-Lab-Developer-Tools#159 ·
维护者通常 1 天内回复
-
Add AdGuard local DNS rewrite tools (list, add, delete)可能已有人在做 @laozhej 于 1 天前认领。 未关闭enhancement severity: medium
难度 3/5 1-2 天 新手友好度 72/100
TMHSDigital/Home-Lab-Developer-Tools#157 ·
维护者通常 1 天内回复
查看 TMHSDigital/Home-Lab-Developer-Tools 的全部 Issue
相似的 Issue
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)未关闭
难度 2/5 1-3 小时 新手友好度 62/100
microsoft/playwright#44289 ·
维护者通常 1 天内回复
-
good first issue
难度 2/5 半天 新手友好度 65/100
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 72/100
blamechris/chroxy#9272 ·
维护者通常 1 天内回复
-
no-repo-link tool-submission
难度 1/5 1 小时以内 新手友好度 66/100
BraveOPotato/NoSignups#2458 ·
-
难度 2/5 1-3 小时 新手友好度 70/100
drmrd/vernacular#1061 ·
维护者通常 1 天内回复