Integration tests import tool modules inside tests and can time out under load

Abierto
#174 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@laozhej ya está trabajando en esto.

Desde el 19/11/2026.

  • #175 de @laozhej — abierto

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
25/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
typescript
Área
testing

Línea de trabajo

Read mcp-server/src/tools/__tests__/integration.test.ts, especially the dynamic imports and mock setup at the cited lines. Run the integration tests with cd mcp-server && npm test to observe the timeout and mock leakage. The acceptance criteria are to remove dynamic imports from test bodies and reset mocks between tests; linked pull request #175 is already open.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

good first issue severity: low testing

Summary

The healthCheck integration tests import the tool module inside the test body, so a cold import can exceed Vitest's 5 s default timeout under a full parallel run. The timed-out test then leaves a queued mock value behind and the next test fails too.

Where

  • mcp-server/src/tools/__tests__/integration.test.ts:42-77 (await import("../healthCheck.js") inside it)
  • mcp-server/src/tools/__tests__/integration.test.ts:37-39 (vi.clearAllMocks() keeps mockResolvedValueOnce queues)

Details

Seen once in a full npx vitest run on Windows:

× returns pass/fail checklist from a single round trip 5858ms   (Test timed out in 5000ms)
× passes node parameter to execSSH                              (expected undefined to be 'nas')

The same file passed alone, and three immediate full reruns passed. The second failure is a cascade: the first test's handler finished after its timeout and consumed the next test's mock, or its queued value was left behind.

Impact

Occasional red CI or release-gate runs that pass on retry, which hides real failures over time.

Suggested fix

  • Import the tool modules at the top of the file (static imports) instead of inside each test.
  • Reset mock state between tests with vi.resetAllMocks() (or mockReset in afterEach) so a timed-out test cannot leak queued values.

Acceptance criteria

  • No dynamic imports inside test bodies in integration.test.ts
  • Mocks are reset between tests

Related: #164

Getting started

  • Relevant files: mcp-server/src/tools/__tests__/integration.test.ts
  • How to run tests: cd mcp-server && npm ci && npm test

Filed by repo-audit/fix-issues at 4c8499a. Severity: low. Effort: S. audit-key: testing|mcp-server/src/tools/__tests__/integration.test.ts|dynamic-import-timeout

Lenguaje dominante
TypeScript
Estrellas
0
Forks
4
Merge medio
10 h 16 min
PR fusionados (30 d)
2

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TMHSDigital/Home-Lab-Developer-Tools

Todos los issues de TMHSDigital/Home-Lab-Developer-Tools

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.