Model M under executor dx12: a fixed 2.5 GiB measuring arena at every context creation

Open
#38 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Active
Tech stack
cpp
Domain
performance

Research direction

Start with clean/runtime/interop/executor_d3d12.cpp and clean/runtime/device_d3d12.cpp to trace the two-pass arena creation and the default size. First compare video memory before, during, and after Model M context creation on Windows and Proton. The issue asks for options to discuss, not a defined implementation; any eventual change must preserve bit-identical output.

Written by the indexing model from the issue text.

Description

area: runtime enhancement needs-hardware-test performance

Discussion #10 reports that Model M allocated a 2,560 MiB buffer next to its 706 MiB arena. That buffer is the first of
two arenas the D3D12 executor creates on the game's device (clean/runtime/interop/executor_d3d12.cpp,
prepare_device): pass 1 makes a device with the default arena (WG_D3D12_ARENA_MB, default 2560 MiB,
clean/runtime/device_d3d12.cpp), runs the whole runtime creation to measure the highest arena offset the network
uses, and destroys it; pass 2 makes the arena that stays, sized to that measurement plus 1 MiB.

What could be better:

  • The measuring arena is a fixed 2.5 GiB whatever the render and output size, so every context creation briefly
    commits 2.5 GiB on the game's device on top of what the game holds, even when the context needs far less. On 8 GB
    cards (RX 9060 XT / 9060, see #3) that is a large share; if the allocation keeps failing for 5 s, Model M falls back.
  • Pass 1's device has no log sink, so its teardown lines are dropped. If its teardown cannot confirm completion, the
    device keeps its GPU objects, the 2.5 GiB arena included, until the game exits, and WrongGPU's log says nothing.
    That would match the report of both buffers side by side.
  • The default and the two passes are documented only in code comments.

To do: first check on Windows and under Proton whether the 2.5 GiB buffer is still allocated after creation (video
memory before, during and after Model M's create). Then options to discuss: measure the need without a full-size arena
(a size from the context's render and output size, or a first pass that only counts allocations), give pass 1's device
the same log sink so its teardown is visible, and document the transient size. The output must stay bit-identical.

Related: Discussion #10, #3

Dominant language
C++
Stars
12
Forks
2
Avg merge
3h 10m
Merged PRs (30d)
171

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from phantoslayer21/wronggpu

All issues in phantoslayer21/wronggpu

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.