Launcher tests: "an older record: update available" fakes a version newer than the test build

Open Beginner friendly
#233 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
80/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
testing

Research direction

Start in clean/installer/tests/run_launcher_tests.py around line 412, where the faked install record for 0.5.1 is written, and compare it with the build version set in clean/installer/tests/run_installer_tests.py around line 2246. Run the launcher test suite to see the failing "an older record: update available" check. Derive the faked record version from the build version so it is older, then add a second check that a record newer than the build reports installed; done when both pass.

Written by the indexing model from the issue text.

Description

bug build

The launcher suite check "an older record: update available" (clean/installer/tests/run_launcher_tests.py, around
line 412) writes an install record for version 0.5.1 and expects the launcher to report update-available. The suite
builds the launcher under test with version 0.3.0-test (clean/installer/tests/run_installer_tests.py, around line
2246), so the faked record is newer than the build. The launcher then correctly reports installed, and the check
fails on every PC, with main as well. The update steps after it still pass only because they use --force.

Fix: fake a record version below the build's version (for example derive it from the build version), or build the
test launcher with a version above any record the suite fakes. The check should then pass, and a second check should
confirm that a record newer than the build is reported as installed, not as an update.

Found while working on #224 (launcher uninstall checks, #219); not part of that fix.

Dominant language
C++
Stars
12
Forks
2
Avg merge
3h 10m
Merged PRs (30d)
171

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from phantoslayer21/wronggpu

All issues in phantoslayer21/wronggpu

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.