Model M under executor dx12: a fixed 2.5 GiB measuring arena at every context creation

Aberta
#38 1 comentário 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
5/5
Tempo estimado
Mais de uma semana
Facilidade para iniciantes
35/100
Tipo de issue
Funcionalidade
Clareza
Precisa de esclarecimento
Status de atividade
Ativa
Stack de tecnologia
cpp
Domínio
performance

Direção de pesquisa

Start with clean/runtime/interop/executor_d3d12.cpp and clean/runtime/device_d3d12.cpp to trace the two-pass arena creation and the default size. First compare video memory before, during, and after Model M context creation on Windows and Proton. The issue asks for options to discuss, not a defined implementation; any eventual change must preserve bit-identical output.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

area: runtime enhancement needs-hardware-test performance

Discussion #10 reports that Model M allocated a 2,560 MiB buffer next to its 706 MiB arena. That buffer is the first of
two arenas the D3D12 executor creates on the game's device (clean/runtime/interop/executor_d3d12.cpp,
prepare_device): pass 1 makes a device with the default arena (WG_D3D12_ARENA_MB, default 2560 MiB,
clean/runtime/device_d3d12.cpp), runs the whole runtime creation to measure the highest arena offset the network
uses, and destroys it; pass 2 makes the arena that stays, sized to that measurement plus 1 MiB.

What could be better:

  • The measuring arena is a fixed 2.5 GiB whatever the render and output size, so every context creation briefly
    commits 2.5 GiB on the game's device on top of what the game holds, even when the context needs far less. On 8 GB
    cards (RX 9060 XT / 9060, see #3) that is a large share; if the allocation keeps failing for 5 s, Model M falls back.
  • Pass 1's device has no log sink, so its teardown lines are dropped. If its teardown cannot confirm completion, the
    device keeps its GPU objects, the 2.5 GiB arena included, until the game exits, and WrongGPU's log says nothing.
    That would match the report of both buffers side by side.
  • The default and the two passes are documented only in code comments.

To do: first check on Windows and under Proton whether the 2.5 GiB buffer is still allocated after creation (video
memory before, during and after Model M's create). Then options to discuss: measure the need without a full-size arena
(a size from the context's render and output size, or a first pass that only counts allocations), give pass 1's device
the same log sink so its teardown is visible, and document the transient size. The output must stay bit-identical.

Related: Discussion #10, #3

Linguagem predominante
C++
Estrelas
12
Forks
2
Merge médio
3h 10min
PRs com merge (30d)
171

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de phantoslayer21/wronggpu

Todas as issues de phantoslayer21/wronggpu

Issues semelhantes

Mais issues de C++

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.