Model M under executor dx12: a fixed 2.5 GiB measuring arena at every context creation

オープン
#38 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
35/100
issue の種類
機能追加
明瞭さ
説明が足りない
活発さ
活発
技術スタック
cpp
領域
performance

調査の方向性

Start with clean/runtime/interop/executor_d3d12.cpp and clean/runtime/device_d3d12.cpp to trace the two-pass arena creation and the default size. First compare video memory before, during, and after Model M context creation on Windows and Proton. The issue asks for options to discuss, not a defined implementation; any eventual change must preserve bit-identical output.

索引モデルが issue の本文から書いたものです。

説明

area: runtime enhancement needs-hardware-test performance

Discussion #10 reports that Model M allocated a 2,560 MiB buffer next to its 706 MiB arena. That buffer is the first of
two arenas the D3D12 executor creates on the game's device (clean/runtime/interop/executor_d3d12.cpp,
prepare_device): pass 1 makes a device with the default arena (WG_D3D12_ARENA_MB, default 2560 MiB,
clean/runtime/device_d3d12.cpp), runs the whole runtime creation to measure the highest arena offset the network
uses, and destroys it; pass 2 makes the arena that stays, sized to that measurement plus 1 MiB.

What could be better:

  • The measuring arena is a fixed 2.5 GiB whatever the render and output size, so every context creation briefly
    commits 2.5 GiB on the game's device on top of what the game holds, even when the context needs far less. On 8 GB
    cards (RX 9060 XT / 9060, see #3) that is a large share; if the allocation keeps failing for 5 s, Model M falls back.
  • Pass 1's device has no log sink, so its teardown lines are dropped. If its teardown cannot confirm completion, the
    device keeps its GPU objects, the 2.5 GiB arena included, until the game exits, and WrongGPU's log says nothing.
    That would match the report of both buffers side by side.
  • The default and the two passes are documented only in code comments.

To do: first check on Windows and under Proton whether the 2.5 GiB buffer is still allocated after creation (video
memory before, during and after Model M's create). Then options to discuss: measure the need without a full-size arena
(a size from the context's render and output size, or a first pass that only counts allocations), give pass 1's device
the same log sink so its teardown is visible, and document the transient size. The output must stay bit-identical.

Related: Discussion #10, #3

主要言語
C++
スター
12
フォーク
2
平均マージ
3時間 10分
マージ済み PR(30日)
171

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

phantoslayer21/wronggpu のほかの issue

phantoslayer21/wronggpu の issue をすべて見る

似ている issue

C++ の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。