Model M under executor dx12: a fixed 2.5 GiB measuring arena at every context creation

Ouverte
#38 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
5/5
Temps estimé
Plus d'une semaine
Accessibilité débutants
35/100
Type d'issue
Fonctionnalité
Clarté
À clarifier
Activité
Active
Stack technique
cpp
Domaine
performance

Piste de recherche

Start with clean/runtime/interop/executor_d3d12.cpp and clean/runtime/device_d3d12.cpp to trace the two-pass arena creation and the default size. First compare video memory before, during, and after Model M context creation on Windows and Proton. The issue asks for options to discuss, not a defined implementation; any eventual change must preserve bit-identical output.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

area: runtime enhancement needs-hardware-test performance

Discussion #10 reports that Model M allocated a 2,560 MiB buffer next to its 706 MiB arena. That buffer is the first of
two arenas the D3D12 executor creates on the game's device (clean/runtime/interop/executor_d3d12.cpp,
prepare_device): pass 1 makes a device with the default arena (WG_D3D12_ARENA_MB, default 2560 MiB,
clean/runtime/device_d3d12.cpp), runs the whole runtime creation to measure the highest arena offset the network
uses, and destroys it; pass 2 makes the arena that stays, sized to that measurement plus 1 MiB.

What could be better:

  • The measuring arena is a fixed 2.5 GiB whatever the render and output size, so every context creation briefly
    commits 2.5 GiB on the game's device on top of what the game holds, even when the context needs far less. On 8 GB
    cards (RX 9060 XT / 9060, see #3) that is a large share; if the allocation keeps failing for 5 s, Model M falls back.
  • Pass 1's device has no log sink, so its teardown lines are dropped. If its teardown cannot confirm completion, the
    device keeps its GPU objects, the 2.5 GiB arena included, until the game exits, and WrongGPU's log says nothing.
    That would match the report of both buffers side by side.
  • The default and the two passes are documented only in code comments.

To do: first check on Windows and under Proton whether the 2.5 GiB buffer is still allocated after creation (video
memory before, during and after Model M's create). Then options to discuss: measure the need without a full-size arena
(a size from the context's render and output size, or a first pass that only counts allocations), give pass 1's device
the same log sink so its teardown is visible, and document the transient size. The output must stay bit-identical.

Related: Discussion #10, #3

Langage dominant
C++
Étoiles
12
Forks
2
Merge moyen
3 h 10 min
PR mergées (30 j)
171

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de phantoslayer21/wronggpu

Toutes les issues de phantoslayer21/wronggpu

Issues similaires

Plus d'issues C++

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.