Model M under executor dx12: a fixed 2.5 GiB measuring arena at every context creation
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 35/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Necesita aclaración
- Estado de actividad
- Activo
- Stack tecnológico
- cpp
- Área
- performance
Línea de trabajo
Start with clean/runtime/interop/executor_d3d12.cpp and clean/runtime/device_d3d12.cpp to trace the two-pass arena creation and the default size. First compare video memory before, during, and after Model M context creation on Windows and Proton. The issue asks for options to discuss, not a defined implementation; any eventual change must preserve bit-identical output.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Discussion #10 reports that Model M allocated a 2,560 MiB buffer next to its 706 MiB arena. That buffer is the first of
two arenas the D3D12 executor creates on the game's device (clean/runtime/interop/executor_d3d12.cpp,
prepare_device): pass 1 makes a device with the default arena (WG_D3D12_ARENA_MB, default 2560 MiB,
clean/runtime/device_d3d12.cpp), runs the whole runtime creation to measure the highest arena offset the network
uses, and destroys it; pass 2 makes the arena that stays, sized to that measurement plus 1 MiB.
What could be better:
- The measuring arena is a fixed 2.5 GiB whatever the render and output size, so every context creation briefly
commits 2.5 GiB on the game's device on top of what the game holds, even when the context needs far less. On 8 GB
cards (RX 9060 XT / 9060, see #3) that is a large share; if the allocation keeps failing for 5 s, Model M falls back. - Pass 1's device has no log sink, so its teardown lines are dropped. If its teardown cannot confirm completion, the
device keeps its GPU objects, the 2.5 GiB arena included, until the game exits, and WrongGPU's log says nothing.
That would match the report of both buffers side by side. - The default and the two passes are documented only in code comments.
To do: first check on Windows and under Proton whether the 2.5 GiB buffer is still allocated after creation (video
memory before, during and after Model M's create). Then options to discuss: measure the need without a full-size arena
(a size from the context's render and output size, or a first pass that only counts allocations), give pass 1's device
the same log sink so its teardown is visible, and document the transient size. The output must stay bit-identical.
Related: Discussion #10, #3
- Lenguaje dominante
- C++
- Estrellas
- 12
- Forks
- 2
- Merge medio
- 3 h 10 min
- PR fusionados (30 d)
- 171
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de phantoslayer21/wronggpu
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
phantoslayer21/wronggpu#275 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
phantoslayer21/wronggpu#274 ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
phantoslayer21/wronggpu#241 ·
Los mantenedores suelen responder en 1 día
-
bug build
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
phantoslayer21/wronggpu#234 ·
Los mantenedores suelen responder en 1 día
-
Launcher tests: "an older record: update available" fakes a version newer than the test buildAbiertobug build
Dificultad 2/5 1-3 horas Aptitud para principiantes 80/100
phantoslayer21/wronggpu#233 ·
Los mantenedores suelen responder en 1 día
Todos los issues de phantoslayer21/wronggpu
Issues similares
-
ai_p2
Dificultad 2/5 1-3 horas Aptitud para principiantes 80/100
ClickHouse/ClickHouse#132519 ·
Los mantenedores suelen responder en 1 día
-
[Bug]: VST3 getMidiControllerAssignment reads past midiControllerToParameter for program changeAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
juce-framework/JUCE#1810 ·
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 82/100
petercorke/robotics-toolbox-python#952 ·
Los mantenedores suelen responder en 1 día
-
NatronRenderer: a Python error in the script (-t / project script) doesn't change the exit statusAbiertofunc:engine type:bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
NatronGitHub/Natron#1276 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 1-3 horas Aptitud para principiantes 77/100
Los mantenedores suelen responder en 1 día