Launcher suite: in a build without Preset K, the state cases leave a game installed and two later checks fail
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 88/100
Research direction
Start in clean/installer/tests/launcher_state_cases.py and read asi_seed_cases, comparing its early return with the normal cleanup path. In a build with -DWRONGGPU_PRESET_K=OFF, verify the game is uninstalled and its folder removed; the launcher verbs suite should pass the shared model data and library page checks.
Written by the indexing model from the issue text.
Description
In clean/installer/tests/launcher_state_cases.py, asi_seed_cases returns early when the install writes no
wronggpu-asi.ini, which is what happens in a launcher built with -DWRONGGPU_PRESET_K=OFF. That early return skips the
uninstall and folder removal the normal path ends with, so the test game "State Asi" stays installed. Two later checks then
fail for a reason that is not their own:
- "last uninstalled ...: the shared model data goes" (State Asi still uses the shared model data);
- the library page dump (a third game is listed).
Seen on 0.6.5 (2b31cbc) with a Preset-K-off launcher build running the launcher verbs suite.
Suggested fix (3 lines): in that early return, uninstall the game and remove its folder as the normal path does. With it,
the verbs suite went from 3 failures to 0 here. Happy to send it as a small PR if that's easier.
- Dominant language
- C++
- Stars
- 12
- Forks
- 2
- Avg merge
- 3h 10m
- Merged PRs (30d)
- 171
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from phantoslayer21/wronggpu
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
phantoslayer21/wronggpu#274 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
phantoslayer21/wronggpu#241 ·
Maintainers usually reply within 1 day
-
bug build
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
phantoslayer21/wronggpu#234 ·
Maintainers usually reply within 1 day
-
bug build
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
phantoslayer21/wronggpu#233 ·
Maintainers usually reply within 1 day
-
area: build-ci build
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
phantoslayer21/wronggpu#56 ·
Maintainers usually reply within 1 day
All issues in phantoslayer21/wronggpu
Similar issues
-
ai_p2
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
ClickHouse/ClickHouse#132519 ·
Maintainers usually reply within 1 day
-
[Bug]: VST3 getMidiControllerAssignment reads past midiControllerToParameter for program changeOpen
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
juce-framework/JUCE#1810 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
petercorke/robotics-toolbox-python#952 ·
Maintainers usually reply within 1 day
-
NatronRenderer: a Python error in the script (-t / project script) doesn't change the exit statusOpenfunc:engine type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
NatronGitHub/Natron#1276 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day