Show the opening name during play and in PGN export

Aperta
#182 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
58/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
javascript
Ambito
full-stack

Direzione di ricerca

Start with js/notation.js for PGN export and js/game.js for the status display, then check index.html and sw.js for the UI and offline cache. Choose a licensed opening data source and match the played moves to its entries. Done when the longest match appears under the status line, persists after reload, is exported as ECO and Opening tags, and works offline.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement help wanted severity: low

Summary

Show the name of the opening being played, for example "Ruy Lopez", under the status line. Also write it into PGN exports as ECO and Opening tags.

Where

  • js/notation.js (PGN export; there is no opening data today)
  • index.html (status area)
  • sw.js (APP_FILES, the offline cache list)

Details

No opening data or label exists anywhere in the code. In js/, "opening" only appears in a comment in js/notation.js.

Impact

This is a cheap learning aid for casual players. It also gives context to the Past games list and to exported PGN.

Suggested fix

  • Bundle a small ECO table (a few hundred lines keyed by SAN move sequence or FEN) as a static file.
  • Add the file to APP_FILES in sw.js so it works offline.
  • Show the longest matching name under the status line.
  • Write ECO and Opening tags in PGN export.

Open questions:

  • Which source to use, and its license. The lichess chess-openings dataset is CC0.
  • Whether to keep showing the last matched name after the game leaves the book.

Acceptance criteria

  • 1.e4 e5 2.Nf3 Nc6 3.Bb5 shows "Ruy Lopez" (or the table's name for it).
  • The name survives a reload and appears in the downloaded PGN.
  • It works offline.

Getting started

  • Relevant files: js/notation.js, js/game.js (status), index.html, sw.js
  • How to run tests: npm test

Filed by repo-audit/full-audit at 01c6a35. Severity: low. Effort: S. audit-key: enhancement|js/notation.js|opening-name

Lingua principale
JavaScript
Stelle
4
Fork
2
Merge medio
22h 16m
PR unite (30g)
9

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TMHSDigital/Static_Chess

Tutte le issue di TMHSDigital/Static_Chess

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.