Show the opening name during play and in PGN export

未关闭
#182 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
58/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
javascript
领域
full-stack

调研方向

Start with js/notation.js for PGN export and js/game.js for the status display, then check index.html and sw.js for the UI and offline cache. Choose a licensed opening data source and match the played moves to its entries. Done when the longest match appears under the status line, persists after reload, is exported as ECO and Opening tags, and works offline.

由索引模型根据 Issue 内容生成。

描述

enhancement help wanted severity: low

Summary

Show the name of the opening being played, for example "Ruy Lopez", under the status line. Also write it into PGN exports as ECO and Opening tags.

Where

  • js/notation.js (PGN export; there is no opening data today)
  • index.html (status area)
  • sw.js (APP_FILES, the offline cache list)

Details

No opening data or label exists anywhere in the code. In js/, "opening" only appears in a comment in js/notation.js.

Impact

This is a cheap learning aid for casual players. It also gives context to the Past games list and to exported PGN.

Suggested fix

  • Bundle a small ECO table (a few hundred lines keyed by SAN move sequence or FEN) as a static file.
  • Add the file to APP_FILES in sw.js so it works offline.
  • Show the longest matching name under the status line.
  • Write ECO and Opening tags in PGN export.

Open questions:

  • Which source to use, and its license. The lichess chess-openings dataset is CC0.
  • Whether to keep showing the last matched name after the game leaves the book.

Acceptance criteria

  • 1.e4 e5 2.Nf3 Nc6 3.Bb5 shows "Ruy Lopez" (or the table's name for it).
  • The name survives a reload and appears in the downloaded PGN.
  • It works offline.

Getting started

  • Relevant files: js/notation.js, js/game.js (status), index.html, sw.js
  • How to run tests: npm test

Filed by repo-audit/full-audit at 01c6a35. Severity: low. Effort: S. audit-key: enhancement|js/notation.js|opening-name

主要语言
JavaScript
星标
4
派生
2
平均合并
22 小时 16 分钟
30 天内合并 PR
9

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TMHSDigital/Static_Chess 的其他 Issue

查看 TMHSDigital/Static_Chess 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。