Regression: a game still ends through four separate code paths
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 45/100
- Tipo di issue
- Refactoring
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- javascript
Direzione di ricerca
Read the listed ending paths in js/game.js, the save inference in js/saved-game.js, and the related tests tests/unit/review-result.test.js and tests/unit/draws-promotion.test.js. Start by running npm test and tracing how each ending updates state, stops the clock, and starts scoring. Done means end-state fields are assigned in one function and the acceptance tests cover each listed ending and its expected state.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
#140 moved the rule decision into gameOutcome, but the end state of a game is still written in four places, and they already behave differently. A related hidden coupling: updateStatusDisplay, which is a render call, also records the players and starts scoring the finished game. Every game ending therefore depends on a redraw happening.
Where
js/game.js:725-745(endWith)js/game.js:856-881(endGameWithoutMove)js/game.js:1686-1694(importPGNsets the end-state fields inline)js/game.js:799-802(Undo reopens a game by hand)js/game.js:637-638,js/game.js:835-836,js/game.js:1760(each caller ofplayMovemust rememberendIfAutomaticDraw)js/saved-game.js:114-122(result inference for old saves)js/game.js:1576-1584(updateStatusDisplaycallsrecordPlayers()andscoreFinishedGame())
Details
importPGN writes the end state itself instead of using either helper:
if (ending) {
isGameOver = true;
gameResult = ending.result;
endedWithoutMove = true;
currentStatus = ending.status;
}
playMove itself decides only checkmate and stalemate. Each caller then has to call endIfAutomaticDraw for repetition, the fifty-move rule and insufficient material.
Impact
The paths already differ: an imported ending plays no sound, and its clock handling differs from endGameWithoutMove. Anything new that must happen when a game ends, such as #160's results record, has to be added to every path. A future caller of playMove that forgets endIfAutomaticDraw would let a game continue past threefold repetition. If a state change ever skips updateStatusDisplay, scoring and player recording are skipped without any error.
Suggested fix
- Add
markEnded(result, status, { withoutMove }). HaveendWith,endGameWithoutMoveandimportPGNall set the end state through it. - Add
playAndJudge(from, to, promo)(that is,playMovefollowed byendIfAutomaticDraw) and use it inmakeMoveandredoMove. KeepimportPGNon plainplayMove, with a comment explaining why. - Call
recordPlayers()andscoreFinishedGame()from these transition helpers, and remove them fromupdateStatusDisplayin a separate commit. - Once old saves without a result can be dropped, remove the inference in
saved-game.js.
Acceptance criteria
- Before starting: one end-to-end test per ending (mate, stalemate, threefold via redo, fifty-move via redo, resignation, agreed draw, flag fall, PGN result tag). Each asserts
gameResult,endedWithoutMove, the status text, that the clock timer stopped, and that scoring started. - The end-state fields are assigned in one function.
Getting started
- Relevant files:
js/game.js,js/saved-game.js,tests/unit/review-result.test.js,tests/unit/draws-promotion.test.js - How to run tests:
npm test
Regression of #140.
Filed by repo-audit/full-audit at 01c6a35. Severity: medium. Effort: M. audit-key: tech-debt|js/game.js|endWith
- Lingua principale
- JavaScript
- Stelle
- 4
- Fork
- 2
- Merge medio
- 22h 16m
- PR unite (30g)
- 9
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di TMHSDigital/Static_Chess
-
enhancement help wanted severity: low
Difficoltà 4/5 3-5 giorni Idoneità per principianti 55/100
TMHSDigital/Static_Chess#184 ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement help wanted severity: low
Difficoltà 4/5 3-5 giorni Idoneità per principianti 58/100
TMHSDigital/Static_Chess#182 ·
I maintainer di solito rispondono entro 1 giorno
-
severity: medium tech-debt
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
TMHSDigital/Static_Chess#171 ·
I maintainer di solito rispondono entro 1 giorno
-
help wanted performance severity: medium
Difficoltà 5/5 Più di una settimana Idoneità per principianti 38/100
TMHSDigital/Static_Chess#168 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement help wanted severity: low
Difficoltà 4/5 3-5 giorni Idoneità per principianti 61/100
TMHSDigital/Static_Chess#161 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di TMHSDigital/Static_Chess
Issue simili
-
priority: low server testing
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
blamechris/chroxy#9277 ·
I maintainer di solito rispondono entro 1 giorno
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
microsoft/playwright#44289 ·
I maintainer di solito rispondono entro 1 giorno
-
Bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
Ionaru/easy-markdown-editor#657 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100
TMHSDigital/Free-Game-Dev-Assets#320 ·
I maintainer di solito rispondono entro 1 giorno
-
area:webapp bug finding
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno