Regression: game.js still holds eight jobs in one 1,862-line scope
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 35/100
- Tipo di issue
- Refactoring
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Attiva
- Stack tecnologico
- javascript
- Ambito
- backend
Direzione di ricerca
Read js/game.js alongside js/notation.js, js/saved-game.js, and js/rules.js; start with the proposed playersFromPGN and replayUndoStack extractions and add direct unit tests for them. Then review statusForOutcome, describeMove, and the material count, using tests/helpers/load-game.js and npm test as described. Done means steps 1–4 are extracted, each extraction is committed separately, and the full suite passes after each.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
#89 split some UI code out (game-ui.js), but js/game.js is still one 1,862-line script. It shares about 30 mutable top-level lets across eight jobs and is the most-changed file in the repo (74 of the last 200 commits). Several functions in it are pure, or close to pure, and can move out with little risk.
Where
js/game.js:6-56: live state, about 30letsjs/game.js:357-595: review and autoplayjs/game.js:1101-1215: clockjs/game.js:1345-1430: persistence and replayjs/game.js:1599-1764: PGN/FEN export and importjs/game.js:1766-1862: exports, including 15 getters only tests use
Details
The file's own section comments list its jobs: move flow, review and autoplay, ending a game without a move, the computer opponent, the clock, hints, persistence and replay, past games, view models, and PGN/FEN import and export.
Functions here that are pure or nearly pure:
replayUndoStack(start, moves, saved), around line 1400playersFromPGN(text), around line 1720statusForOutcome, around line 717- the material count in
updateCapturedDisplay, around lines 1496-1501 isThreefoldRepetition, around line 1293
Impact
Every recent feature (Redo, the Play button, random side, rebuilding the undo stack on load) had to edit this file and keep all of its globals in mind. Pure logic in it can only be tested by loading the whole page in jsdom (tests/helpers/load-game.js).
Suggested fix
Extract in small PRs, pure code first. Keep the old global name as a one-line alias until its callers move, so every PR leaves the page working.
- Move
playersFromPGNtonotation.js. - Move
replayUndoStacktosaved-game.jsorrules.js, asrebuildUndoStack(start, moves, savedKey). - Move
statusForOutcomeand the move sentence ofdescribeMoveinto a small text module, or intoreview.js. - Move the material count into
rules.jsasmaterialBalance(board). - Only then consider extracting the clock section behind an object that
game.jsowns.
Acceptance criteria
- Before starting: unit tests that call
replayUndoStackandplayersFromPGNdirectly, and characterization tests for thedescribeMovetext of castling, en passant, promotion and check. - Each extraction is its own commit, and the full suite passes after each one.
-
game.jsloses steps 1-4.
Getting started
- Relevant files:
js/game.js,js/notation.js,js/saved-game.js,js/rules.js,tests/helpers/load-game.js - How to run tests:
npm test
Regression of #89.
Filed by repo-audit/full-audit at 01c6a35. Severity: medium. Effort: L. audit-key: tech-debt|js/game.js|module-structure
- Lingua principale
- JavaScript
- Stelle
- 4
- Fork
- 2
- Merge medio
- 22h 16m
- PR unite (30g)
- 9
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di TMHSDigital/Static_Chess
-
enhancement help wanted severity: low
Difficoltà 4/5 3-5 giorni Idoneità per principianti 55/100
TMHSDigital/Static_Chess#184 ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement help wanted severity: low
Difficoltà 4/5 3-5 giorni Idoneità per principianti 58/100
TMHSDigital/Static_Chess#182 ·
I maintainer di solito rispondono entro 1 giorno
-
help wanted severity: medium tech-debt
Difficoltà 4/5 3-5 giorni Idoneità per principianti 45/100
TMHSDigital/Static_Chess#173 ·
I maintainer di solito rispondono entro 1 giorno
-
help wanted performance severity: medium
Difficoltà 5/5 Più di una settimana Idoneità per principianti 38/100
TMHSDigital/Static_Chess#168 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement help wanted severity: low
Difficoltà 4/5 3-5 giorni Idoneità per principianti 61/100
TMHSDigital/Static_Chess#161 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di TMHSDigital/Static_Chess
Issue simili
-
priority: low server testing
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
blamechris/chroxy#9277 ·
I maintainer di solito rispondono entro 1 giorno
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
microsoft/playwright#44289 ·
I maintainer di solito rispondono entro 1 giorno
-
Bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
Ionaru/easy-markdown-editor#657 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100
TMHSDigital/Free-Game-Dev-Assets#320 ·
I maintainer di solito rispondono entro 1 giorno
-
area:webapp bug finding
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno