Show the opening name during play and in PGN export

Abierto
#182 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
58/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
javascript
Área
full-stack

Línea de trabajo

Start with js/notation.js for PGN export and js/game.js for the status display, then check index.html and sw.js for the UI and offline cache. Choose a licensed opening data source and match the played moves to its entries. Done when the longest match appears under the status line, persists after reload, is exported as ECO and Opening tags, and works offline.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement help wanted severity: low

Summary

Show the name of the opening being played, for example "Ruy Lopez", under the status line. Also write it into PGN exports as ECO and Opening tags.

Where

  • js/notation.js (PGN export; there is no opening data today)
  • index.html (status area)
  • sw.js (APP_FILES, the offline cache list)

Details

No opening data or label exists anywhere in the code. In js/, "opening" only appears in a comment in js/notation.js.

Impact

This is a cheap learning aid for casual players. It also gives context to the Past games list and to exported PGN.

Suggested fix

  • Bundle a small ECO table (a few hundred lines keyed by SAN move sequence or FEN) as a static file.
  • Add the file to APP_FILES in sw.js so it works offline.
  • Show the longest matching name under the status line.
  • Write ECO and Opening tags in PGN export.

Open questions:

  • Which source to use, and its license. The lichess chess-openings dataset is CC0.
  • Whether to keep showing the last matched name after the game leaves the book.

Acceptance criteria

  • 1.e4 e5 2.Nf3 Nc6 3.Bb5 shows "Ruy Lopez" (or the table's name for it).
  • The name survives a reload and appears in the downloaded PGN.
  • It works offline.

Getting started

  • Relevant files: js/notation.js, js/game.js (status), index.html, sw.js
  • How to run tests: npm test

Filed by repo-audit/full-audit at 01c6a35. Severity: low. Effort: S. audit-key: enhancement|js/notation.js|opening-name

Lenguaje dominante
JavaScript
Estrellas
4
Forks
2
Merge medio
22 h 16 min
PR fusionados (30 d)
9

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TMHSDigital/Static_Chess

Todos los issues de TMHSDigital/Static_Chess

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.