Show the opening name during play and in PGN export

未關閉
#182 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
58/100
Issue 類型
功能
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
javascript
領域
full-stack

研究方向

Start with js/notation.js for PGN export and js/game.js for the status display, then check index.html and sw.js for the UI and offline cache. Choose a licensed opening data source and match the played moves to its entries. Done when the longest match appears under the status line, persists after reload, is exported as ECO and Opening tags, and works offline.

由索引模型根據 Issue 內容生成。

描述

enhancement help wanted severity: low

Summary

Show the name of the opening being played, for example "Ruy Lopez", under the status line. Also write it into PGN exports as ECO and Opening tags.

Where

  • js/notation.js (PGN export; there is no opening data today)
  • index.html (status area)
  • sw.js (APP_FILES, the offline cache list)

Details

No opening data or label exists anywhere in the code. In js/, "opening" only appears in a comment in js/notation.js.

Impact

This is a cheap learning aid for casual players. It also gives context to the Past games list and to exported PGN.

Suggested fix

  • Bundle a small ECO table (a few hundred lines keyed by SAN move sequence or FEN) as a static file.
  • Add the file to APP_FILES in sw.js so it works offline.
  • Show the longest matching name under the status line.
  • Write ECO and Opening tags in PGN export.

Open questions:

  • Which source to use, and its license. The lichess chess-openings dataset is CC0.
  • Whether to keep showing the last matched name after the game leaves the book.

Acceptance criteria

  • 1.e4 e5 2.Nf3 Nc6 3.Bb5 shows "Ruy Lopez" (or the table's name for it).
  • The name survives a reload and appears in the downloaded PGN.
  • It works offline.

Getting started

  • Relevant files: js/notation.js, js/game.js (status), index.html, sw.js
  • How to run tests: npm test

Filed by repo-audit/full-audit at 01c6a35. Severity: low. Effort: S. audit-key: enhancement|js/notation.js|opening-name

主要語言
JavaScript
星號
4
分支
2
平均合併
22 小時 16 分鐘
30 天內合併 PR
9

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

TMHSDigital/Static_Chess 的其他 Issue

查看 TMHSDigital/Static_Chess 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。