Regression: legal-move generation still dominates search, so hard never gets past depth 3
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 38/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- javascript
- Ambito
- backend, performance
Direzione di ricerca
Start with js/rules.js at legalMovesFrom, allLegalMoves and allLegalCaptures, then read the search and quiescence call sites in js/ai.js. Run npm test and use the provided Node benchmark steps to compare move generation with evaluation. Done means all acceptance criteria pass, including the generator cross-checks and the hard depth 4 timing target.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
#86 was closed, but legal-move generation is still the main cost of the engine search. It costs about 40 times as much as evaluation. As a result, the "hard" level never finishes a search deeper than its base depth of 3, and its maxDepth: 8 cannot be reached.
Where
js/rules.js:243-270(legalMovesFrom)js/rules.js:302-360(allLegalMoves,allLegalCaptures)js/ai.js:16(hard: { depth: 3, timeMs: 1000, maxDepth: 8 })js/ai.js:118,js/ai.js:201(search and quiescence call sites)
Details
For every piece, legalMovesFrom tests all 64 target squares with isPseudoLegalMove and isPathObstructed. For each candidate move it copies the whole board (applyMove) and runs isInCheck. The search calls this at every interior node, and quiescence calls allLegalCaptures, which also runs one applyMove per capture.
Measured in Node on a middlegame position:
| Operation | Cost |
|---|---|
allLegalMoves |
685 µs per call |
allLegalCaptures |
173 µs per call |
evaluatePosition |
17.5 µs per call |
| Depth-3 search | 1.1 s, 10.7k nodes |
| Depth-4 search | 16.9 s, 115k nodes |
Impact
hard is allowed about 1 s, or at most 3 s on the clock (searchBudget), so iterative deepening never completes depth 4. The worker then spends the rest of its allowance on a depth-4 search that is thrown away. Hard plays at its fixed depth, and every computer move and every hint keeps a core busy for the full allowance. On phones, depth 3 alone takes longer than the 1 s allowance. The same constant also makes review scoring (see the issue on review steps) and the no-worker fallback slow.
Steps to reproduce
- Time
searchPositionat depth 3 and depth 4 on a middlegame position, usingrules.jsandai.jsin Node or in a jest test. - Compare the cost of
allLegalMoveswith the cost ofevaluatePosition.
Suggested fix
- Generate pseudo-legal moves from piece offsets and sliding rays instead of scanning all 64 squares.
- Check legality only where it can fail: king moves, pinned pieces (one ray scan from the king), en passant, and positions in check.
- Or defer the legality test until the search actually plays a move, and count a node with no legal child as mate or stalemate.
- Make and unmake moves on one board (or a flat 64-entry array) instead of copying it for each move.
- Then add move ordering (MVV-LVA, killer moves).
Keep the public functions in rules.js as wrappers so callers and tests don't change. The existing generator cross-check tests ("quick generators agree") act as a perft-style safety net.
Acceptance criteria
-
allLegalMovesis at least 5 times faster on the benchmark position. - Hard completes depth 4 within its 1 s allowance on desktop.
- All rules tests and generator cross-checks pass unchanged.
Getting started
- Relevant files:
js/rules.js,js/ai.js,tests/unit/rules.test.js,tests/unit/ai-strength.test.js - How to run tests:
npm test
Regression of #86.
Filed by repo-audit/full-audit at 01c6a35. Severity: medium. Effort: M. audit-key: performance|js/rules.js|legalMovesFrom
- Lingua principale
- JavaScript
- Stelle
- 4
- Fork
- 2
- Merge medio
- 22h 16m
- PR unite (30g)
- 9
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di TMHSDigital/Static_Chess
-
enhancement help wanted severity: low
Difficoltà 4/5 3-5 giorni Idoneità per principianti 55/100
TMHSDigital/Static_Chess#184 ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement help wanted severity: low
Difficoltà 4/5 3-5 giorni Idoneità per principianti 58/100
TMHSDigital/Static_Chess#182 ·
I maintainer di solito rispondono entro 1 giorno
-
help wanted severity: medium tech-debt
Difficoltà 4/5 3-5 giorni Idoneità per principianti 45/100
TMHSDigital/Static_Chess#173 ·
I maintainer di solito rispondono entro 1 giorno
-
severity: medium tech-debt
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
TMHSDigital/Static_Chess#171 ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement help wanted severity: low
Difficoltà 4/5 3-5 giorni Idoneità per principianti 61/100
TMHSDigital/Static_Chess#161 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di TMHSDigital/Static_Chess
Issue simili
-
priority: low server testing
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
blamechris/chroxy#9277 ·
I maintainer di solito rispondono entro 1 giorno
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
microsoft/playwright#44289 ·
I maintainer di solito rispondono entro 1 giorno
-
Bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
Ionaru/easy-markdown-editor#657 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100
TMHSDigital/Free-Game-Dev-Assets#320 ·
I maintainer di solito rispondono entro 1 giorno
-
area:webapp bug finding
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno