P2: CI's HOLODECK_CHROMIUM (auto-updating runner Chrome) counts as a pinned browser for the fidelity gate
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
Research direction
Start with resolveChromium in packages/editor-2.5d-react/src/test-support/chromium.ts, which marks any existing HOLODECK_CHROMIUM as pinned, and with the fidelity gate's pinning assertion that relies on it. Pick one of the two fixes the issue offers (record the browser version per platform record, or pin a Chrome for Testing build in CI), and check with a maintainer first since that is a design choice. Done when a test shows that pointing HOLODECK_CHROMIUM at an auto-updating system Chrome no longer counts as pinned.
Written by the indexing model from the issue text.
Description
From the GPT Sol 6.1 review of #84. This is not a regression: CI already used the runner's Chrome before #84.
resolveChromium in packages/editor-2.5d-react/src/test-support/chromium.ts marks any existing HOLODECK_CHROMIUM as pinned: true. On CI that variable points at the GitHub runner's preinstalled Google Chrome, which changes with each image update (154 and 155 so far). The fidelity gate's pinning assertion therefore passes on a browser that can move under an unchanged Linux record. Chrome 154 and 155 happened to render byte-identically; a later version might not.
Fix: record the browser version with each platform record and fail (or warn, and skip the ratchet) when the version differs. Alternatively, use a fixed Chrome for Testing build in CI once the install hang (#29) is worked around. Add a test showing that pointing HOLODECK_CHROMIUM at an auto-updating system Chrome does not by itself count as pinned.
🤖 Generated with Claude Code
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 0
- Avg merge
- 14h 55m
- Merged PRs (30d)
- 26
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hyperdrive-technology/holodeck
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
hyperdrive-technology/holodeck#142 ·
Maintainers usually reply within 1 day
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
hyperdrive-technology/holodeck#141 ·
Maintainers usually reply within 1 day
-
review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
hyperdrive-technology/holodeck#106 ·
Maintainers usually reply within 1 day
-
review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
hyperdrive-technology/holodeck#105 ·
Maintainers usually reply within 1 day
-
assetUrlProblem: data:image check uses the un-normalised URL, so ' data:image/png...' is rejectedOpenarea:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
hyperdrive-technology/holodeck#104 ·
Maintainers usually reply within 1 day
All issues in hyperdrive-technology/holodeck
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
chrisparsons83/flexspotff#215 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
vitest-dev/vitest#11633 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day