LogoAnchor.quaternion/normal are required: type break for hosts building anchors for the exported LogoPlane
Maintainers usually reply within 1 day
A pull request for this has already been merged.
- #140 by @dezlitz — merged
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 62/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- react, typescript
- Domain
- frontend
Research direction
Read the LogoAnchor export in src/objects/index.ts and the LogoPlane export in src/registry/index.ts, then inspect logoPlaneQuaternion and the lift mentioned in the issue. Decide whether to make quaternion and normal optional with the FLAT default or document the breaking change under a Changed heading in the changelog; done when the chosen approach resolves the compatibility concern.
Written by the indexing model from the issue text.
Description
#140 adds required quaternion and normal fields to the public LogoAnchor type (exported from @holodeck/editor-2.5d-react via src/objects/index.ts:38), and LogoPlane (exported from src/registry/index.ts:36) takes a LogoAnchor. A host constructing an anchor literal for LogoPlane stops type-checking. No in-tree or core consumer does this today (grep), so not a blocker.
Fix options: make both fields optional with the FLAT default inside logoPlaneQuaternion / the lift, or note the break under a Changed heading in CHANGELOG (pre-1.0, 0.1.0).
Found in review of #140.
🤖 Generated with Claude Code
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 0
- Avg merge
- 10h 39m
- Merged PRs (30d)
- 38
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hyperdrive-technology/holodeck
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
hyperdrive-technology/holodeck#196 ·
Maintainers usually reply within 1 day
-
area:docs review-finding
Difficulty 1/5 Under an hour Newbie friendliness 70/100
hyperdrive-technology/holodeck#180 ·
Maintainers usually reply within 1 day
-
Flaky E3 test: native cut with no keydown (holodeck#123) in editing-ux-render.test.tsPossibly taken @dezlitz claimed this today. Openarea:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
hyperdrive-technology/holodeck#141 ·
Maintainers usually reply within 1 day
-
assetUrlProblem: data:image check uses the un-normalised URL, so ' data:image/png...' is rejectedOpenarea:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
hyperdrive-technology/holodeck#104 ·
Maintainers usually reply within 1 day
-
agent area:holodeck good first issue priority:p2
Difficulty 1/5 Under an hour Newbie friendliness 72/100
hyperdrive-technology/holodeck#64 ·
Maintainers usually reply within 1 day
All issues in hyperdrive-technology/holodeck
Similar issues
-
bug priority: P2
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
wayfinder:task
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
bug customer-reported data-plane question Service Attention Storage
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
Azure/azure-rest-api-specs#47397 · 2 comments ·
Maintainers usually reply within 1 day
-
Claude thinking budget can shrink capped Haiku responses to 2,048 tokensPossibly taken @DavyMassoneto claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
diegosouzapw/OmniRoute#17109 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
paperclipai/paperclip#16785 ·
Maintainers usually reply within 1 day