assetUrlProblem: data:image check uses the un-normalised URL, so ' data:image/png...' is rejected
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 88/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- react, typescript
Research direction
Start in packages/editor-2.5d-react/src/objects/validate.ts and read assetUrlProblem alongside normalizeUrlForScheme. Add a unit case for a data:image/ URL with leading whitespace or C0 characters, then run the relevant unit test. Done when the normalized URL is used for the data-image check and the new case passes.
Written by the indexing model from the issue text.
Description
From the #93 re-review. packages/editor-2.5d-react/src/objects/validate.ts assetUrlProblem: the scheme is read from normalizeUrlForScheme(v) but the data:image/ test runs on raw v, so a data image URL with leading whitespace/C0 (which browsers accept) is refused. Fail-safe (false negative, not a bypass). Fix: run the /^data:image\//i test on the normalised string; add a unit case.
🤖 Generated with Claude Code
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 0
- Avg merge
- 14h 55m
- Merged PRs (30d)
- 26
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hyperdrive-technology/holodeck
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
hyperdrive-technology/holodeck#142 ·
Maintainers usually reply within 1 day
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
hyperdrive-technology/holodeck#141 ·
Maintainers usually reply within 1 day
-
review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
hyperdrive-technology/holodeck#106 ·
Maintainers usually reply within 1 day
-
review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
hyperdrive-technology/holodeck#105 ·
Maintainers usually reply within 1 day
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
hyperdrive-technology/holodeck#99 ·
Maintainers usually reply within 1 day
All issues in hyperdrive-technology/holodeck
Similar issues
-
Object parameters lose their structure when resources is enabledPossibly taken @asts-top claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 2 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
jaegertracing/jaeger-ui#4618 ·
Maintainers usually reply within 1 day
-
pending close triaging
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
anomalyco/opencode#56765 · 1 comment ·
Maintainers usually reply within 1 day
-
area:plugins enhancement platform:vscode
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
anthropics/claude-code#103166 ·
Maintainers usually reply within 1 day
-
Types: FlashListProps imports ViewabilityConfig from react-native, removed in RN 0.87+Possibly taken @efegokdemir claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Shopify/flash-list#2540 ·