Flaky E3 test: native cut with no keydown (holodeck#123) in editing-ux-render.test.ts
Maintainers usually reply within 1 day
A pull request for this has already been merged.
- #197 by @dezlitz — merged
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- react, typescript
- Domain
- testing
Research direction
Start with packages/editor-2.5d-react/src/editor/editing-ux-render.test.ts, especially the test at line 136, and read how clickCell, settle/waitForRendered, and selected are used. Add settling after scene mutations before subsequent clicks, and check that tank-c is selected before Ctrl/Cmd+X. Done means the test reliably verifies that the native cut copies and deletes exactly once.
Written by the indexing model from the issue text.
Description
Seen intermittently in CI/local runs during the #140 follow-up batch. packages/editor-2.5d-react/src/editor/editing-ux-render.test.ts:136 ("a native cut with no keydown (browser Edit > Cut) copies and deletes, once").
Likely causes: clickCell(page, toScreen, 6, 0) right after the menu-cut delete re-renders the scene without waiting for a rendered frame (waitForRendered/settle), so the click can miss the tank and the following keyboard cut deletes nothing (timeout on objects.length === 2); same for the initial select via clickCell(0,0) before the first frame settles.
Fix: await settle(page) (or waitForRendered) after each scene mutation before the next clickCell, and assert selected(page) is tank-c before pressing Ctrl/Cmd+X so a failure points at the click, not the cut.
Found in review of #140.
🤖 Generated with Claude Code
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 0
- Avg merge
- 11h 21m
- Merged PRs (30d)
- 41
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hyperdrive-technology/holodeck
-
area:ci review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
hyperdrive-technology/holodeck#208 ·
Maintainers usually reply within 1 day
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
hyperdrive-technology/holodeck#207 ·
Maintainers usually reply within 1 day
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
hyperdrive-technology/holodeck#206 ·
Maintainers usually reply within 1 day
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
hyperdrive-technology/holodeck#205 ·
Maintainers usually reply within 1 day
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
hyperdrive-technology/holodeck#201 · 1 comment ·
Maintainers usually reply within 1 day
All issues in hyperdrive-technology/holodeck
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
maniator/verticopolis#1303 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
components-web-app/docs#297 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
appwrite/mcp-for-docs#23 · 1 comment ·
-
`@vanilla-extract/turbopack-plugin`: "getImageSize is not a function" with Next.js 16.4.x when a `.css.ts` file imports an imagePossibly taken @aevarOrigo claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
vanilla-extract-css/vanilla-extract#1799 · 1 comment ·
-
native
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
prime-radiant-inc/evener#4839 ·
Maintainers usually reply within 1 day