provider-http: SseIdTracker keeps an undispatched id across reconnect
Maintainers usually reply within 1 day
A pull request for this has already been merged.
- #188 by @dezlitz — merged
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 88/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
- Domain
- backend, networking
Research direction
Start with packages/provider-http/src/sse-id.ts and inspect SseIdTracker.resetStream() and the existing tests for stream ID handling. Reproduce the described disconnect after id: pending\n but before the blank line, then add a test covering that interruption and reconnect. Done when the pending ID is not promoted by the next stream's first blank line, while the committed ID remains intact.
Written by the indexing model from the issue text.
Description
From the GPT review of #89 (head 9002547), P2. packages/provider-http/src/sse-id.ts resetStream() keeps buffer. Steps: receive id: committed\n\n, then id: pending\n, then the stream drops before the blank line. On the next stream the first blank line (e.g. a heartbeat) promotes 'pending' to lastEventId. Fix: in resetStream() set buffer = lastEventId. Add a test that interrupts the stream between the id line and the frame terminator.
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 0
- Avg merge
- 10h 39m
- Merged PRs (30d)
- 38
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hyperdrive-technology/holodeck
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
hyperdrive-technology/holodeck#201 ·
Maintainers usually reply within 1 day
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
hyperdrive-technology/holodeck#196 ·
Maintainers usually reply within 1 day
-
area:docs review-finding
Difficulty 1/5 Under an hour Newbie friendliness 70/100
hyperdrive-technology/holodeck#180 ·
Maintainers usually reply within 1 day
-
Flaky E3 test: native cut with no keydown (holodeck#123) in editing-ux-render.test.tsPossibly taken @dezlitz claimed this 1 day ago. Openarea:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
hyperdrive-technology/holodeck#141 ·
Maintainers usually reply within 1 day
-
assetUrlProblem: data:image check uses the un-normalised URL, so ' data:image/png...' is rejectedOpenarea:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
hyperdrive-technology/holodeck#104 ·
Maintainers usually reply within 1 day
All issues in hyperdrive-technology/holodeck
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
jessepollak/home#2223 ·
Maintainers usually reply within 1 day
-
grep fixture corpus test follows the corpus's loop symlink under the receipt runner (fails on main)Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
code-yeongyu/senpi#3756 ·
Maintainers usually reply within 1 day
-
org:external package:deepagents priority:triage topic:memory topic:middleware type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
langchain-ai/deepagents#7059 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
osmlab/name-suggestion-index#12992 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
hemilabs/ui-monorepo#2506 ·
Maintainers usually reply within 1 day