P2: CI's HOLODECK_CHROMIUM (auto-updating runner Chrome) counts as a pinned browser for the fidelity gate

Abierto
  • ¿Algo no está bien?
#87 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
typescript
Área
ci-cd, testing

Línea de trabajo

Start with resolveChromium in packages/editor-2.5d-react/src/test-support/chromium.ts, which marks any existing HOLODECK_CHROMIUM as pinned, and with the fidelity gate's pinning assertion that relies on it. Pick one of the two fixes the issue offers (record the browser version per platform record, or pin a Chrome for Testing build in CI), and check with a maintainer first since that is a design choice. Done when a test shows that pointing HOLODECK_CHROMIUM at an auto-updating system Chrome no longer counts as pinned.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:ci area:holodeck priority:p2 review-finding

From the GPT Sol 6.1 review of #84. This is not a regression: CI already used the runner's Chrome before #84.

resolveChromium in packages/editor-2.5d-react/src/test-support/chromium.ts marks any existing HOLODECK_CHROMIUM as pinned: true. On CI that variable points at the GitHub runner's preinstalled Google Chrome, which changes with each image update (154 and 155 so far). The fidelity gate's pinning assertion therefore passes on a browser that can move under an unchanged Linux record. Chrome 154 and 155 happened to render byte-identically; a later version might not.

Fix: record the browser version with each platform record and fail (or warn, and skip the ratchet) when the version differs. Alternatively, use a fixed Chrome for Testing build in CI once the install hang (#29) is worked around. Add a test showing that pointing HOLODECK_CHROMIUM at an auto-updating system Chrome does not by itself count as pinned.

🤖 Generated with Claude Code

Lenguaje dominante
TypeScript
Estrellas
0
Forks
0
Merge medio
12 h 24 min
PR fusionados (30 d)
46

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de hyperdrive-technology/holodeck

Todos los issues de hyperdrive-technology/holodeck

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.