Test hygiene: empty cli tests, broken coverage script, vitest 1.x, redundant SDK re-tests, pump GLB test, Blender check
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 32/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- blender, github-actions, react, typescript
- Domain
- ci-cd, documentation, testing
Research direction
This is a bundle of separate test-cleanup items, and several need a maintainer decision first: whether to add a Blender CI job or document the valve check as local-only, and whether to align vitest on 4.x. Start with the named spots: packages/cli config, the root package.json test script, HolodeckViewer3D.test.tsx:86, and registry.test.ts:84. Pick one item, such as the CONTRIBUTING.md:33 wording against scripts/smoke-dist.mjs, and confirm the decision in the thread before starting.
Written by the indexing model from the issue text.
Description
packages/clihas a vitest config but no tests and no CI job; emptypackage-lock.json.- Root
package.jsontestscript runs nothing; root lists vitest ^4.1.9 but packages lock 1.6.1. Align with core (vitest 4). editor-2d-reacttest:coverageneeds@vitest/coverage-v8, which is not installed.viewer-3d-react/src/HolodeckViewer3D.test.tsx:86re-tests@holodeck/sdkcreateTransform/createMaterial(covered byholodeck-sdk/ts/src/index.test.ts): delete;editor-2.5d-react/src/registry/registry.test.ts:84overlaps the SDK's atomic-install tests (keep only the consumer-side assertion; the conformance kit run is intended).pumpGLB has no part-specific contract test (valve, kettle, mash-tun, fermenter, brite-tank, heat-exchanger do).valve-glb.test.tsBlender byte-identical rebuild never runs in CI (no Blender): add a scheduled job with Blender headless, or document it as a local-only check.CONTRIBUTING.md:33says CI does not run the built-package smoke; it does (scripts/smoke-dist.mjs).- Untracked
packages/importer-template,packages/provider-templatewithoutpackage.json.
From the 2026-10 test-tier audit (core PR on branch docs/testing-strategy, docs/TESTING_STRATEGY.md).
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 0
- Avg merge
- 14h 55m
- Merged PRs (30d)
- 26
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hyperdrive-technology/holodeck
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
hyperdrive-technology/holodeck#142 ·
Maintainers usually reply within 1 day
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
hyperdrive-technology/holodeck#141 ·
Maintainers usually reply within 1 day
-
review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
hyperdrive-technology/holodeck#106 ·
Maintainers usually reply within 1 day
-
review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
hyperdrive-technology/holodeck#105 ·
Maintainers usually reply within 1 day
-
assetUrlProblem: data:image check uses the un-normalised URL, so ' data:image/png...' is rejectedOpenarea:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
hyperdrive-technology/holodeck#104 ·
Maintainers usually reply within 1 day
All issues in hyperdrive-technology/holodeck
Similar issues
-
area:security documentation effort:S priority:P2
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
app:web meta:ops
Difficulty 2/5 Half a day Newbie friendliness 78/100
osu-tournament-rating/otr#1113 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
typegoose/mongodb-memory-server#1040 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 92/100