Test hygiene: empty cli tests, broken coverage script, vitest 1.x, redundant SDK re-tests, pump GLB test, Blender check

Abierto
  • ¿Algo no está bien?
#35 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
32/100
Tipo de issue
Refactorización
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
blender, github-actions, react, typescript
Área
ci-cd, documentation, testing

Línea de trabajo

This is a bundle of separate test-cleanup items, and several need a maintainer decision first: whether to add a Blender CI job or document the valve check as local-only, and whether to align vitest on 4.x. Start with the named spots: packages/cli config, the root package.json test script, HolodeckViewer3D.test.tsx:86, and registry.test.ts:84. Pick one item, such as the CONTRIBUTING.md:33 wording against scripts/smoke-dist.mjs, and confirm the decision in the thread before starting.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

agent area:ci area:holodeck priority:p2
  • packages/cli has a vitest config but no tests and no CI job; empty package-lock.json.
  • Root package.json test script runs nothing; root lists vitest ^4.1.9 but packages lock 1.6.1. Align with core (vitest 4).
  • editor-2d-react test:coverage needs @vitest/coverage-v8, which is not installed.
  • viewer-3d-react/src/HolodeckViewer3D.test.tsx:86 re-tests @holodeck/sdk createTransform/createMaterial (covered by holodeck-sdk/ts/src/index.test.ts): delete; editor-2.5d-react/src/registry/registry.test.ts:84 overlaps the SDK's atomic-install tests (keep only the consumer-side assertion; the conformance kit run is intended).
  • pump GLB has no part-specific contract test (valve, kettle, mash-tun, fermenter, brite-tank, heat-exchanger do).
  • valve-glb.test.ts Blender byte-identical rebuild never runs in CI (no Blender): add a scheduled job with Blender headless, or document it as a local-only check.
  • CONTRIBUTING.md:33 says CI does not run the built-package smoke; it does (scripts/smoke-dist.mjs).
  • Untracked packages/importer-template, packages/provider-template without package.json.

From the 2026-10 test-tier audit (core PR on branch docs/testing-strategy, docs/TESTING_STRATEGY.md).

Lenguaje dominante
TypeScript
Estrellas
0
Forks
0
Merge medio
12 h 24 min
PR fusionados (30 d)
46

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de hyperdrive-technology/holodeck

Todos los issues de hyperdrive-technology/holodeck

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.