Add AdGuard local DNS rewrite tools (list, add, delete)

Abierto
#157 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@laozhej ya está trabajando en esto.

Desde el 20/11/2026.

  • #177 de @laozhej — abierto

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
72/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript

Línea de trabajo

Start by reading mcp-server/src/tools/adguardFilterToggle.ts to see how an AdGuard POST is authenticated and wrapped in a confirm gate, then find where tools are registered so the two new ones follow the same shape. Check whether an AdGuard request/response type module already exists before adding new ones, and mirror the existing tool tests under mcp-server (npm test, npm run typecheck). Finish by adding both tools to skills/dns-management/SKILL.md around the cited lines. Done means list returns rewrites, set validates domain/answer and requires confirmation, and the skill documents both.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement severity: medium

Summary

The dns-management skill covers creating local DNS rewrites and cites POST /control/rewrite/add, but no tool lists or changes rewrites.

Where

  • skills/dns-management/SKILL.md:4, :25, :52, :79
  • mcp-server/src/tools/adguardFilterToggle.ts (existing authenticated, confirm-gated AdGuard POST)

Details

service.home.lab -> Pi IP is the most common home-lab DNS task. Today it needs a hand edit or a free-form nodeExec curl.

Impact

The skill's main workflow has no safe tool path.

Suggested fix

Add read-only homelab_adguardRewrites (GET /control/rewrite/list) and confirm-gated homelab_adguardRewriteSet (action: add|delete, domain, answer validated as IP or hostname), reusing the AdGuard auth helper and the filter-toggle request pattern. Add both to the skill.

Acceptance criteria

  • List and set tools registered with correct annotations
  • Set tool confirm-gated with input validation
  • Skill updated

Getting started

  • Relevant files: mcp-server/src/tools/adguardFilterToggle.ts, skills/dns-management/SKILL.md
  • How to run tests: cd mcp-server && npm install && npm test (and npm run typecheck); structure tests: pip install -r requirements-test.txt && pytest tests/ -v
  • Conventions: see CLAUDE.md and CONTRIBUTING.md

Filed by repo-audit/full-audit at 636fefb. Severity: medium. Effort: S. audit-key: enhancement|skills/dns-management/SKILL.md|homelab_adguardRewrites

Lenguaje dominante
TypeScript
Estrellas
0
Forks
4
Merge medio
10 h 16 min
PR fusionados (30 d)
2

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TMHSDigital/Home-Lab-Developer-Tools

Todos los issues de TMHSDigital/Home-Lab-Developer-Tools

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.