Opt-in local audit log of executed state-changing tool calls

Abierto
#159 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
72/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
node.js, typescript

Línea de trabajo

Start by reading mcp-server/src/utils/confirm-param.ts — it is the shared gate all twelve confirmed tools pass through, so the append belongs there rather than in each tool. Look at mcp-server/src/tools/nodeExec.ts:22 for the shape of a gated call and at mcp-server/src/index.ts:130 for the existing (only) logging pattern, then run cd mcp-server && npm install && npm test plus npm run typecheck. Done means: with HOMELAB_AUDIT_LOG set, a confirmed gated call appends one JSON line with timestamp, tool, node, host, masked command, exit status and duration, no secret values, covered by a unit test.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement severity: medium

Summary

Twelve tools change remote state behind confirm: true, but nothing records what was executed.

Where

  • mcp-server/src/tools/nodeExec.ts:22
  • mcp-server/src/index.ts:130 (the only logging in src)

Details

After an agent session a user cannot answer "what did the AI run on my Pi, and when", which matters most for nodeExec, backupRestore and composeDown.

Impact

No after-the-fact record of agent actions on the user's hardware.

Suggested fix

Add opt-in HOMELAB_AUDIT_LOG=<path>: every confirmed gated call appends one JSON line (timestamp, tool, node, host, masked command, exit status, duration). Hook it in one place shared by the gated tools. Never log secret values.

Open questions: also log cancelled previews and dry runs? Rotate the file?

Acceptance criteria

  • Gated calls append a JSON line when the variable is set
  • No secret values in the log
  • Unit test

Getting started

  • Relevant files: mcp-server/src/utils/confirm-param.ts, mcp-server/src/tools/nodeExec.ts, mcp-server/src/index.ts
  • How to run tests: cd mcp-server && npm install && npm test (and npm run typecheck); structure tests: pip install -r requirements-test.txt && pytest tests/ -v
  • Conventions: see CLAUDE.md and CONTRIBUTING.md

Filed by repo-audit/full-audit at 636fefb. Severity: medium. Effort: M. audit-key: enhancement|mcp-server/src/utils/confirm-param.ts|audit-log

Lenguaje dominante
TypeScript
Estrellas
0
Forks
4
Merge medio
10 h 16 min
PR fusionados (30 d)
2

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TMHSDigital/Home-Lab-Developer-Tools

Todos los issues de TMHSDigital/Home-Lab-Developer-Tools

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.