Review player: Scan for secrets button that pre-fills redaction boxes from OCR
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Anfängerfreundlichkeit
- 73/100
- Issue-Typ
- Feature
- Klarheit
- Klar beschrieben
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- typescript
- Bereich
- backend-api-design, frontend
Rechercherichtung
Start with assets/ui/player.js and assets/ui/player.html to see how redaction boxes are drawn, listed, and exported, then read src/tools/findText.ts to understand the redact: true result. Add a keyboard-accessible scan action that turns each hit into a suggested box labeled with its kind, never its text; allow removal and report the result in the status line. Done when a player test with a stubbed tool result covers the scan path and the acceptance criteria pass.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Summary
The review player only redacts boxes a person draws or types. The server can already find on-screen secrets by OCR, so the player should offer a "Scan for secrets" button that pre-fills the boxes for the person to check before export.
Where
assets/ui/player.js:363-369(export builds{ op: "redact", regions }from hand-drawn boxes only)assets/ui/player.html:116-118(controls: Play, Draw redaction box. No scan action)src/utils/pipelineStep.ts:38-44(pipelineredactalready acceptssecrets: true | regex)src/tools/findText.ts(redact: truereturns boxes ready forredact_region)
Details
The player exists so a person can review a recording before it is shared, but finding every token, email, or key by eye across a whole recording is the hard part. The OCR secret scan already exists server-side and is used by bug_report and the pipeline recipes. The player never calls it.
Suggested fix
- Add a Scan for secrets button. It calls
find_text(redact: true) on the sampled frames (or the kept range) and adds each hit as a box, marked "suggested" in#boxListwith its matched kind (not the value). - Suggested boxes can be removed like drawn ones. Export sends them as ordinary
regions(withstart/endonce per-box time ranges land). - Alternative: a checkbox "Also blur secrets found by OCR" that adds
secrets: trueto the redact step. Simpler, but the person cannot see or veto the boxes.
Acceptance criteria
- One click adds boxes for OCR-detected secrets on the current recording
- Box labels show the secret kind, never the text
- Works by keyboard; status line reports "N suggested boxes" or "No secrets found"
- Player test covers the scan path with a stubbed tool result
Getting started
- Relevant files:
assets/ui/player.js,assets/ui/player.html,src/tools/findText.ts - Tests:
npm test; lint:npm run lint
Filed by repo-audit/feature-ideas at 1ac339f. Severity: high. Effort: M. audit-key: enhancement|assets/ui/player.js|scanSecrets
- Vorherrschende Sprache
- TypeScript
- Sterne
- 1
- Forks
- 4
- Ø Merge
- 8 Std. 17 Min.
- Gemergte PRs (30 T.)
- 46
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus TMHSDigital/screencast-mcp
-
effort: small good first issue priority: medium testing
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 84/100
TMHSDigital/screencast-mcp#351 · 2 Kommentare ·
Maintainer antworten meist innerhalb von 1 Tag
-
effort: small enhancement good first issue priority: low
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 72/100
TMHSDigital/screencast-mcp#380 ·
Maintainer antworten meist innerhalb von 1 Tag
-
effort: medium enhancement help wanted priority: medium
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 56/100
TMHSDigital/screencast-mcp#379 ·
Maintainer antworten meist innerhalb von 1 Tag
-
effort: medium enhancement help wanted priority: medium
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 57/100
TMHSDigital/screencast-mcp#378 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Review player: limit a redaction box to a time windowEvtl. vergeben @lucky0559 hat das vor 2 Tagen übernommen. Offeneffort: small enhancement good first issue priority: medium
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 25/100
TMHSDigital/screencast-mcp#377 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in TMHSDigital/screencast-mcp
Ähnliche Issues
-
clawsweeper:needs-maintainer-review clawsweeper:needs-product-decision clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster P3
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
openclaw/openclaw#203385 · 1 Kommentar · 1 Reaktion ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
nwverse/persona#12800 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 80/100
Maintainer antworten meist innerhalb von 1 Tag
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
microsoft/playwright#44289 ·
Maintainer antworten meist innerhalb von 1 Tag
-
good first issue
Schwierigkeit 2/5 Ein halber Tag Anfängerfreundlichkeit 65/100
Maintainer antworten meist innerhalb von 1 Tag