Review player: Scan for secrets button that pre-fills redaction boxes from OCR

Offen
#374 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
73/100
Issue-Typ
Feature
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
typescript

Rechercherichtung

Start with assets/ui/player.js and assets/ui/player.html to see how redaction boxes are drawn, listed, and exported, then read src/tools/findText.ts to understand the redact: true result. Add a keyboard-accessible scan action that turns each hit into a suggested box labeled with its kind, never its text; allow removal and report the result in the status line. Done when a player test with a stubbed tool result covers the scan path and the acceptance criteria pass.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

effort: medium enhancement help wanted priority: high

Summary

The review player only redacts boxes a person draws or types. The server can already find on-screen secrets by OCR, so the player should offer a "Scan for secrets" button that pre-fills the boxes for the person to check before export.

Where

  • assets/ui/player.js:363-369 (export builds { op: "redact", regions } from hand-drawn boxes only)
  • assets/ui/player.html:116-118 (controls: Play, Draw redaction box. No scan action)
  • src/utils/pipelineStep.ts:38-44 (pipeline redact already accepts secrets: true | regex)
  • src/tools/findText.ts (redact: true returns boxes ready for redact_region)

Details

The player exists so a person can review a recording before it is shared, but finding every token, email, or key by eye across a whole recording is the hard part. The OCR secret scan already exists server-side and is used by bug_report and the pipeline recipes. The player never calls it.

Suggested fix

  • Add a Scan for secrets button. It calls find_text (redact: true) on the sampled frames (or the kept range) and adds each hit as a box, marked "suggested" in #boxList with its matched kind (not the value).
  • Suggested boxes can be removed like drawn ones. Export sends them as ordinary regions (with start/end once per-box time ranges land).
  • Alternative: a checkbox "Also blur secrets found by OCR" that adds secrets: true to the redact step. Simpler, but the person cannot see or veto the boxes.

Acceptance criteria

  • One click adds boxes for OCR-detected secrets on the current recording
  • Box labels show the secret kind, never the text
  • Works by keyboard; status line reports "N suggested boxes" or "No secrets found"
  • Player test covers the scan path with a stubbed tool result

Getting started

  • Relevant files: assets/ui/player.js, assets/ui/player.html, src/tools/findText.ts
  • Tests: npm test; lint: npm run lint

Filed by repo-audit/feature-ideas at 1ac339f. Severity: high. Effort: M. audit-key: enhancement|assets/ui/player.js|scanSecrets

Vorherrschende Sprache
TypeScript
Sterne
1
Forks
4
Ø Merge
8 Std. 17 Min.
Gemergte PRs (30 T.)
46

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus TMHSDigital/screencast-mcp

Alle Issues in TMHSDigital/screencast-mcp

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.