Review player: keyboard shortcuts (play/pause, set IN/OUT, draw, delete box)

Offen
#380 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
72/100
Issue-Typ
Feature
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
node.js, typescript

Rechercherichtung

Start with assets/ui/player.js, especially the existing slider keydown handlers and the keyTarget pattern. Read the player markup in assets/ui/player.html and run npm test to locate the relevant tests. Add the player-wide shortcuts, an accessible keyboard-reachable shortcut list, and tests for the key map; done means the listed shortcuts work outside text and number inputs and the tests pass.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

effort: small enhancement good first issue priority: low

Summary

The review player has no player-wide shortcuts. Keys only work while one of the three sliders has focus (arrows, Page Up/Down, Home/End). Reviewing a recording means reaching for the mouse for play/pause, setting IN/OUT at the playhead, and deleting a box.

Where

  • assets/ui/player.js:214-241 (keydown handlers on #seek, #hIn, #hOut only)
  • assets/ui/player.js:243 (Play is click-only)
  • assets/ui/player.html:118 (hint text documents only drag and arrows)

Suggested fix

Add a keydown handler on the player root that ignores events from inputs:

  • Space / K play/pause, J / L step back/forward one frame, , / . as aliases
  • I / O set IN / OUT at the playhead
  • D toggle draw mode, Delete remove the focused box, Esc cancel a draft box
  • ? shows a small shortcut list, and the hint line mentions it

Acceptance criteria

  • Shortcuts work wherever focus is in the player, except inside text and number inputs
  • Shortcut list is reachable by keyboard and announced to screen readers
  • Tests for the key map (pure function like keyTarget)

Getting started

  • Relevant file: assets/ui/player.js (keyTarget shows the existing pattern)
  • Tests: npm test

Filed by repo-audit/feature-ideas at 1ac339f. Severity: low. Effort: S. audit-key: enhancement|assets/ui/player.js|shortcuts

Vorherrschende Sprache
TypeScript
Sterne
1
Forks
4
Ø Merge
8 Std. 17 Min.
Gemergte PRs (30 T.)
46

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus TMHSDigital/screencast-mcp

Alle Issues in TMHSDigital/screencast-mcp

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.