Review player: limit a redaction box to a time window

Offen
#377 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@lucky0559 arbeitet bereits daran.

Seit 19.11.2026.

  • #381 von @lucky0559 — ohne Merge geschlossen
  • #382 von @lucky0559 — offen

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
25/100
Issue-Typ
Feature
Klarheit
Klar beschrieben
Aktivitätsstatus
Veraltet
Tech-Stack
typescript
Bereich
frontend

Rechercherichtung

Start with assets/ui/player.html and assets/ui/player.js to trace the box form, box list, stage drawing, and export; read src/tools/redactRegion.ts for the existing start and end behavior. Run npm test and inspect the generated regions assertion. Done means boxes can be time-limited by pointer and keyboard, display only while active, and export their window; an open linked pull request indicates work is already underway.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

effort: small enhancement good first issue priority: medium

Summary

Redaction boxes drawn in the review player cover the whole kept range. redact_region and pipeline redact already support a start..end window per region, but the player cannot set one. A notification that sits on screen for 3 seconds gets blurred for the whole video.

Where

  • assets/ui/player.html:137-146 (box form: X, Y, W, H only)
  • assets/ui/player.js:367 (regions: S.boxes.map((b) => ({ ...b })), with no time fields)
  • src/tools/redactRegion.ts:15 ("each optionally limited to start..end seconds")

Suggested fix

  • A new box defaults to "whole video". Add a From playhead / To playhead pair (or a small range on the timeline under the box) to limit it.
  • Show each box's window in #boxList (01:10.0–01:13.5) and only draw a box on the stage while the playhead is inside its window.
  • Export includes start/end when set.

Acceptance criteria

  • Boxes can be limited to a time window, by pointer and by keyboard
  • Stage shows only the boxes active at the current frame
  • Export passes the window. A test checks the generated regions

Getting started

  • Relevant files: assets/ui/player.js, assets/ui/player.html
  • Tests: npm test

Filed by repo-audit/feature-ideas at 1ac339f. Severity: medium. Effort: S. audit-key: enhancement|assets/ui/player.js|boxTimeRange

Vorherrschende Sprache
TypeScript
Sterne
1
Forks
4
Ø Merge
8 Std. 17 Min.
Gemergte PRs (30 T.)
46

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus TMHSDigital/screencast-mcp

Alle Issues in TMHSDigital/screencast-mcp

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.