Review player: Scan for secrets button that pre-fills redaction boxes from OCR

Ouverte
#374 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
73/100
Type d'issue
Fonctionnalité
Clarté
Clairement spécifiée
Activité
Active
Stack technique
typescript

Piste de recherche

Start with assets/ui/player.js and assets/ui/player.html to see how redaction boxes are drawn, listed, and exported, then read src/tools/findText.ts to understand the redact: true result. Add a keyboard-accessible scan action that turns each hit into a suggested box labeled with its kind, never its text; allow removal and report the result in the status line. Done when a player test with a stubbed tool result covers the scan path and the acceptance criteria pass.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

effort: medium enhancement help wanted priority: high

Summary

The review player only redacts boxes a person draws or types. The server can already find on-screen secrets by OCR, so the player should offer a "Scan for secrets" button that pre-fills the boxes for the person to check before export.

Where

  • assets/ui/player.js:363-369 (export builds { op: "redact", regions } from hand-drawn boxes only)
  • assets/ui/player.html:116-118 (controls: Play, Draw redaction box. No scan action)
  • src/utils/pipelineStep.ts:38-44 (pipeline redact already accepts secrets: true | regex)
  • src/tools/findText.ts (redact: true returns boxes ready for redact_region)

Details

The player exists so a person can review a recording before it is shared, but finding every token, email, or key by eye across a whole recording is the hard part. The OCR secret scan already exists server-side and is used by bug_report and the pipeline recipes. The player never calls it.

Suggested fix

  • Add a Scan for secrets button. It calls find_text (redact: true) on the sampled frames (or the kept range) and adds each hit as a box, marked "suggested" in #boxList with its matched kind (not the value).
  • Suggested boxes can be removed like drawn ones. Export sends them as ordinary regions (with start/end once per-box time ranges land).
  • Alternative: a checkbox "Also blur secrets found by OCR" that adds secrets: true to the redact step. Simpler, but the person cannot see or veto the boxes.

Acceptance criteria

  • One click adds boxes for OCR-detected secrets on the current recording
  • Box labels show the secret kind, never the text
  • Works by keyboard; status line reports "N suggested boxes" or "No secrets found"
  • Player test covers the scan path with a stubbed tool result

Getting started

  • Relevant files: assets/ui/player.js, assets/ui/player.html, src/tools/findText.ts
  • Tests: npm test; lint: npm run lint

Filed by repo-audit/feature-ideas at 1ac339f. Severity: high. Effort: M. audit-key: enhancement|assets/ui/player.js|scanSecrets

Langage dominant
TypeScript
Étoiles
1
Forks
4
Merge moyen
8 h 17 min
PR mergées (30 j)
46

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TMHSDigital/screencast-mcp

Toutes les issues de TMHSDigital/screencast-mcp

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.