Review player: Scan for secrets button that pre-fills redaction boxes from OCR

オープン
#374 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
73/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
typescript

調査の方向性

Start with assets/ui/player.js and assets/ui/player.html to see how redaction boxes are drawn, listed, and exported, then read src/tools/findText.ts to understand the redact: true result. Add a keyboard-accessible scan action that turns each hit into a suggested box labeled with its kind, never its text; allow removal and report the result in the status line. Done when a player test with a stubbed tool result covers the scan path and the acceptance criteria pass.

索引モデルが issue の本文から書いたものです。

説明

effort: medium enhancement help wanted priority: high

Summary

The review player only redacts boxes a person draws or types. The server can already find on-screen secrets by OCR, so the player should offer a "Scan for secrets" button that pre-fills the boxes for the person to check before export.

Where

  • assets/ui/player.js:363-369 (export builds { op: "redact", regions } from hand-drawn boxes only)
  • assets/ui/player.html:116-118 (controls: Play, Draw redaction box. No scan action)
  • src/utils/pipelineStep.ts:38-44 (pipeline redact already accepts secrets: true | regex)
  • src/tools/findText.ts (redact: true returns boxes ready for redact_region)

Details

The player exists so a person can review a recording before it is shared, but finding every token, email, or key by eye across a whole recording is the hard part. The OCR secret scan already exists server-side and is used by bug_report and the pipeline recipes. The player never calls it.

Suggested fix

  • Add a Scan for secrets button. It calls find_text (redact: true) on the sampled frames (or the kept range) and adds each hit as a box, marked "suggested" in #boxList with its matched kind (not the value).
  • Suggested boxes can be removed like drawn ones. Export sends them as ordinary regions (with start/end once per-box time ranges land).
  • Alternative: a checkbox "Also blur secrets found by OCR" that adds secrets: true to the redact step. Simpler, but the person cannot see or veto the boxes.

Acceptance criteria

  • One click adds boxes for OCR-detected secrets on the current recording
  • Box labels show the secret kind, never the text
  • Works by keyboard; status line reports "N suggested boxes" or "No secrets found"
  • Player test covers the scan path with a stubbed tool result

Getting started

  • Relevant files: assets/ui/player.js, assets/ui/player.html, src/tools/findText.ts
  • Tests: npm test; lint: npm run lint

Filed by repo-audit/feature-ideas at 1ac339f. Severity: high. Effort: M. audit-key: enhancement|assets/ui/player.js|scanSecrets

主要言語
TypeScript
スター
1
フォーク
4
平均マージ
8時間 17分
マージ済み PR(30日)
46

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

TMHSDigital/screencast-mcp のほかの issue

TMHSDigital/screencast-mcp の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。