Review player: Scan for secrets button that pre-fills redaction boxes from OCR

Abierto
#374 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
73/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript

Línea de trabajo

Start with assets/ui/player.js and assets/ui/player.html to see how redaction boxes are drawn, listed, and exported, then read src/tools/findText.ts to understand the redact: true result. Add a keyboard-accessible scan action that turns each hit into a suggested box labeled with its kind, never its text; allow removal and report the result in the status line. Done when a player test with a stubbed tool result covers the scan path and the acceptance criteria pass.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

effort: medium enhancement help wanted priority: high

Summary

The review player only redacts boxes a person draws or types. The server can already find on-screen secrets by OCR, so the player should offer a "Scan for secrets" button that pre-fills the boxes for the person to check before export.

Where

  • assets/ui/player.js:363-369 (export builds { op: "redact", regions } from hand-drawn boxes only)
  • assets/ui/player.html:116-118 (controls: Play, Draw redaction box. No scan action)
  • src/utils/pipelineStep.ts:38-44 (pipeline redact already accepts secrets: true | regex)
  • src/tools/findText.ts (redact: true returns boxes ready for redact_region)

Details

The player exists so a person can review a recording before it is shared, but finding every token, email, or key by eye across a whole recording is the hard part. The OCR secret scan already exists server-side and is used by bug_report and the pipeline recipes. The player never calls it.

Suggested fix

  • Add a Scan for secrets button. It calls find_text (redact: true) on the sampled frames (or the kept range) and adds each hit as a box, marked "suggested" in #boxList with its matched kind (not the value).
  • Suggested boxes can be removed like drawn ones. Export sends them as ordinary regions (with start/end once per-box time ranges land).
  • Alternative: a checkbox "Also blur secrets found by OCR" that adds secrets: true to the redact step. Simpler, but the person cannot see or veto the boxes.

Acceptance criteria

  • One click adds boxes for OCR-detected secrets on the current recording
  • Box labels show the secret kind, never the text
  • Works by keyboard; status line reports "N suggested boxes" or "No secrets found"
  • Player test covers the scan path with a stubbed tool result

Getting started

  • Relevant files: assets/ui/player.js, assets/ui/player.html, src/tools/findText.ts
  • Tests: npm test; lint: npm run lint

Filed by repo-audit/feature-ideas at 1ac339f. Severity: high. Effort: M. audit-key: enhancement|assets/ui/player.js|scanSecrets

Lenguaje dominante
TypeScript
Estrellas
1
Forks
4
Merge medio
8 h 17 min
PR fusionados (30 d)
46

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TMHSDigital/screencast-mcp

Todos los issues de TMHSDigital/screencast-mcp

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.