Add AdGuard local DNS rewrite tools (list, add, delete)

Offen
#157 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@laozhej arbeitet bereits daran.

Seit 20.11.2026.

  • #177 von @laozhej — offen

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
72/100
Issue-Typ
Feature
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
typescript
Bereich
networking, tooling

Rechercherichtung

Start by reading mcp-server/src/tools/adguardFilterToggle.ts to see how an AdGuard POST is authenticated and wrapped in a confirm gate, then find where tools are registered so the two new ones follow the same shape. Check whether an AdGuard request/response type module already exists before adding new ones, and mirror the existing tool tests under mcp-server (npm test, npm run typecheck). Finish by adding both tools to skills/dns-management/SKILL.md around the cited lines. Done means list returns rewrites, set validates domain/answer and requires confirmation, and the skill documents both.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

enhancement severity: medium

Summary

The dns-management skill covers creating local DNS rewrites and cites POST /control/rewrite/add, but no tool lists or changes rewrites.

Where

  • skills/dns-management/SKILL.md:4, :25, :52, :79
  • mcp-server/src/tools/adguardFilterToggle.ts (existing authenticated, confirm-gated AdGuard POST)

Details

service.home.lab -> Pi IP is the most common home-lab DNS task. Today it needs a hand edit or a free-form nodeExec curl.

Impact

The skill's main workflow has no safe tool path.

Suggested fix

Add read-only homelab_adguardRewrites (GET /control/rewrite/list) and confirm-gated homelab_adguardRewriteSet (action: add|delete, domain, answer validated as IP or hostname), reusing the AdGuard auth helper and the filter-toggle request pattern. Add both to the skill.

Acceptance criteria

  • List and set tools registered with correct annotations
  • Set tool confirm-gated with input validation
  • Skill updated

Getting started

  • Relevant files: mcp-server/src/tools/adguardFilterToggle.ts, skills/dns-management/SKILL.md
  • How to run tests: cd mcp-server && npm install && npm test (and npm run typecheck); structure tests: pip install -r requirements-test.txt && pytest tests/ -v
  • Conventions: see CLAUDE.md and CONTRIBUTING.md

Filed by repo-audit/full-audit at 636fefb. Severity: medium. Effort: S. audit-key: enhancement|skills/dns-management/SKILL.md|homelab_adguardRewrites

Vorherrschende Sprache
TypeScript
Sterne
0
Forks
4
Ø Merge
10 Std. 16 Min.
Gemergte PRs (30 T.)
2

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus TMHSDigital/Home-Lab-Developer-Tools

Alle Issues in TMHSDigital/Home-Lab-Developer-Tools

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.