winget uninstall leaves tracking catalog rows when the package was correlated through the tracking catalog

未关闭
#6,657 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
69/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
cpp
领域
cli, databases

调研方向

Start with RecordUninstall in src/AppInstallerCLICore/Workflows/UninstallFlow.cpp and trace how the correlated installed version’s ID and source are passed to PackageTrackingCatalog::RecordUninstall in src/AppInstallerRepositoryCore/PackageTrackingCatalog.cpp. Read the linked CompositeSource.cpp methods to understand the ID/source behavior, then find or add coverage for the tracking-correlated uninstall case. Done when uninstall removes the package’s rows from installed.db, preventing later ARP entries with the same product code from being correlated to it.

由索引模型根据 Issue 内容生成。

描述

Command-Uninstall
Relevant area(s)

WinGet CLI

Relevant command(s)

winget uninstall

Brief description of your issue

When the installed (ARP) entry was correlated to the available package through the source's tracking catalog, winget uninstall reports success but leaves that package's rows in the tracking catalog (installed.db). Any later ARP entry with the same product code is then correlated to the old package again.

From the source (v1.29.380; the same code is on master today):

  • RecordUninstall seeds UninstallCorrelatedSources with GetInstalledVersion(package) first (UninstallFlow.cpp#L442-L463).
  • For a tracking-correlated package, that installed version is a CompositeInstalledVersion. Its GetSource() returns the tracking (remote) source (CompositeSource.cpp#L313-L322), but its GetProperty(Id) returns the base installed version's id, i.e. the ARP-derived id such as ARP\User\X64\<Key> (CompositeSource.cpp#L292-L301).
  • So the first item is {ARP-derived id, winget source}. The available package from that same source is then skipped by the same-source check (UninstallFlow.cpp#L39-L61), and PackageTrackingCatalog::RecordUninstall looks up the ARP-derived id, matches nothing and removes nothing (PackageTrackingCatalog.cpp#L292-L309).
Steps to reproduce
  1. Start with tracking-catalog rows for a package <Id> (source winget) whose recorded product codes include a plain ARP key name <Key>, and no ARP entry named <Key>. Seen with qup1010.FilePilot: its rows for 1.0.5 and 1.0.7 record product code filepilot (from the ProductCode collision in microsoft/winget-pkgs#448131).
  2. Create a per-user ARP entry HKCU\Software\Microsoft\Windows\CurrentVersion\Uninstall\<Key> with DisplayName, Publisher, DisplayVersion, and UninstallString = QuietUninstallString = cmd /c reg delete "HKCU\Software\Microsoft\Windows\CurrentVersion\Uninstall\<Key>" /f.
  3. winget list --id <Id> --exact shows the entry as <Id>.
  4. winget uninstall --id <Id> --exact --source winget --silent
  5. Check a copy of %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Microsoft.Winget.Source_8wekyb3d8bbwe\installed.db for manifest rows of <Id>.
Expected behavior

<Id>'s rows are removed from the tracking catalog, so a later ARP entry with the same product code is no longer correlated to <Id>.

Actual behavior

Successfully uninstalled (exit code 0). The log shows the uninstall string ran, and the ARP entry is gone. All of <Id>'s rows are still in installed.db, which the uninstall did not write to. When another product later creates an ARP entry with the same key name, winget list --id <Id> --exact again shows it as <Id> with an upgrade available.

I have only verified this case. Reading the code, any uninstall where the installed version was correlated through the tracking catalog would leave its rows behind.

Environment
Windows Package Manager v1.29.380
Windows: Windows.Desktop v10.0.26300.9818
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.29.380.0
主要语言
C++
星标
26.6k
派生
1.8k
平均合并
3 天 10 小时
30 天内合并 PR
41

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

microsoft/winget-cli 的其他 Issue

查看 microsoft/winget-cli 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。