winget uninstall leaves tracking catalog rows when the package was correlated through the tracking catalog
Les mainteneurs répondent en général sous 2 jours
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Accessibilité débutants
- 69/100
Piste de recherche
Start with RecordUninstall in src/AppInstallerCLICore/Workflows/UninstallFlow.cpp and trace how the correlated installed version’s ID and source are passed to PackageTrackingCatalog::RecordUninstall in src/AppInstallerRepositoryCore/PackageTrackingCatalog.cpp. Read the linked CompositeSource.cpp methods to understand the ID/source behavior, then find or add coverage for the tracking-correlated uninstall case. Done when uninstall removes the package’s rows from installed.db, preventing later ARP entries with the same product code from being correlated to it.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Relevant area(s)
WinGet CLI
Relevant command(s)
winget uninstall
Brief description of your issue
When the installed (ARP) entry was correlated to the available package through the source's tracking catalog, winget uninstall reports success but leaves that package's rows in the tracking catalog (installed.db). Any later ARP entry with the same product code is then correlated to the old package again.
From the source (v1.29.380; the same code is on master today):
RecordUninstallseedsUninstallCorrelatedSourceswithGetInstalledVersion(package)first (UninstallFlow.cpp#L442-L463).- For a tracking-correlated package, that installed version is a
CompositeInstalledVersion. ItsGetSource()returns the tracking (remote) source (CompositeSource.cpp#L313-L322), but itsGetProperty(Id)returns the base installed version's id, i.e. the ARP-derived id such asARP\User\X64\<Key>(CompositeSource.cpp#L292-L301). - So the first item is {ARP-derived id, winget source}. The available package from that same source is then skipped by the same-source check (UninstallFlow.cpp#L39-L61), and
PackageTrackingCatalog::RecordUninstalllooks up the ARP-derived id, matches nothing and removes nothing (PackageTrackingCatalog.cpp#L292-L309).
Steps to reproduce
- Start with tracking-catalog rows for a package
<Id>(sourcewinget) whose recorded product codes include a plain ARP key name<Key>, and no ARP entry named<Key>. Seen withqup1010.FilePilot: its rows for 1.0.5 and 1.0.7 record product codefilepilot(from the ProductCode collision in microsoft/winget-pkgs#448131). - Create a per-user ARP entry
HKCU\Software\Microsoft\Windows\CurrentVersion\Uninstall\<Key>withDisplayName,Publisher,DisplayVersion, andUninstallString=QuietUninstallString=cmd /c reg delete "HKCU\Software\Microsoft\Windows\CurrentVersion\Uninstall\<Key>" /f. winget list --id <Id> --exactshows the entry as<Id>.winget uninstall --id <Id> --exact --source winget --silent- Check a copy of
%LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Microsoft.Winget.Source_8wekyb3d8bbwe\installed.dbfor manifest rows of<Id>.
Expected behavior
<Id>'s rows are removed from the tracking catalog, so a later ARP entry with the same product code is no longer correlated to <Id>.
Actual behavior
Successfully uninstalled (exit code 0). The log shows the uninstall string ran, and the ARP entry is gone. All of <Id>'s rows are still in installed.db, which the uninstall did not write to. When another product later creates an ARP entry with the same key name, winget list --id <Id> --exact again shows it as <Id> with an upgrade available.
I have only verified this case. Reading the code, any uninstall where the installed version was correlated through the tracking catalog would leave its rows behind.
Environment
Windows Package Manager v1.29.380
Windows: Windows.Desktop v10.0.26300.9818
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.29.380.0
- Langage dominant
- C++
- Étoiles
- 26.6k
- Forks
- 1.8k
- Merge moyen
- 3 j 10 h
- PR mergées (30 j)
- 41
Préparer son environnement
- Aucun Dockerfile ni fichier Docker Compose
- Propose un modèle de pull request
- Lire le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de microsoft/winget-cli
-
Issue-Docs Needs-Triage
Difficulté 2/5 1-3 heures Accessibilité débutants 70/100
microsoft/winget-cli#6692 ·
Les mainteneurs répondent en général sous 2 jours
-
Issue-Docs Possible-Duplicate
Difficulté 2/5 1-3 heures Accessibilité débutants 76/100
microsoft/winget-cli#6493 · 1 commentaire ·
Les mainteneurs répondent en général sous 2 jours
-
WinGetSourceCreator: PackWithMappingFile should verify makeappx.exe exists before invoking itOuverteIssue-Feature
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
microsoft/winget-cli#6427 ·
Les mainteneurs répondent en général sous 2 jours
-
Issue-Docs msstore
Difficulté 2/5 1-3 heures Accessibilité débutants 64/100
microsoft/winget-cli#6331 · 1 commentaire ·
Les mainteneurs répondent en général sous 2 jours
-
Command-Source Issue-Bug
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
microsoft/winget-cli#6148 ·
Les mainteneurs répondent en général sous 2 jours
Toutes les issues de microsoft/winget-cli
Issues similaires
-
feat
Difficulté 2/5 1-3 heures Accessibilité débutants 65/100
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
-
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
stratum-mining/sv2-tp#167 ·
Les mainteneurs répondent en général sous 1 jour
-
better error message bug low priority semantics strings
Difficulté 2/5 1-3 heures Accessibilité débutants 72/100
Les mainteneurs répondent en général sous 1 jour
-
Sign up button opens the Sign in page instead of the Sign up page for Enterprise edition serversOuverteauth bug ui/ux
Difficulté 2/5 1-3 heures Accessibilité débutants 72/100
MerginMaps/mobile#4795 ·
Les mainteneurs répondent en général sous 2 jours