winget uninstall leaves tracking catalog rows when the package was correlated through the tracking catalog
Maintainer antworten meist innerhalb von 2 Tagen
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Anfängerfreundlichkeit
- 69/100
Rechercherichtung
Start with RecordUninstall in src/AppInstallerCLICore/Workflows/UninstallFlow.cpp and trace how the correlated installed version’s ID and source are passed to PackageTrackingCatalog::RecordUninstall in src/AppInstallerRepositoryCore/PackageTrackingCatalog.cpp. Read the linked CompositeSource.cpp methods to understand the ID/source behavior, then find or add coverage for the tracking-correlated uninstall case. Done when uninstall removes the package’s rows from installed.db, preventing later ARP entries with the same product code from being correlated to it.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Relevant area(s)
WinGet CLI
Relevant command(s)
winget uninstall
Brief description of your issue
When the installed (ARP) entry was correlated to the available package through the source's tracking catalog, winget uninstall reports success but leaves that package's rows in the tracking catalog (installed.db). Any later ARP entry with the same product code is then correlated to the old package again.
From the source (v1.29.380; the same code is on master today):
RecordUninstallseedsUninstallCorrelatedSourceswithGetInstalledVersion(package)first (UninstallFlow.cpp#L442-L463).- For a tracking-correlated package, that installed version is a
CompositeInstalledVersion. ItsGetSource()returns the tracking (remote) source (CompositeSource.cpp#L313-L322), but itsGetProperty(Id)returns the base installed version's id, i.e. the ARP-derived id such asARP\User\X64\<Key>(CompositeSource.cpp#L292-L301). - So the first item is {ARP-derived id, winget source}. The available package from that same source is then skipped by the same-source check (UninstallFlow.cpp#L39-L61), and
PackageTrackingCatalog::RecordUninstalllooks up the ARP-derived id, matches nothing and removes nothing (PackageTrackingCatalog.cpp#L292-L309).
Steps to reproduce
- Start with tracking-catalog rows for a package
<Id>(sourcewinget) whose recorded product codes include a plain ARP key name<Key>, and no ARP entry named<Key>. Seen withqup1010.FilePilot: its rows for 1.0.5 and 1.0.7 record product codefilepilot(from the ProductCode collision in microsoft/winget-pkgs#448131). - Create a per-user ARP entry
HKCU\Software\Microsoft\Windows\CurrentVersion\Uninstall\<Key>withDisplayName,Publisher,DisplayVersion, andUninstallString=QuietUninstallString=cmd /c reg delete "HKCU\Software\Microsoft\Windows\CurrentVersion\Uninstall\<Key>" /f. winget list --id <Id> --exactshows the entry as<Id>.winget uninstall --id <Id> --exact --source winget --silent- Check a copy of
%LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Microsoft.Winget.Source_8wekyb3d8bbwe\installed.dbfor manifest rows of<Id>.
Expected behavior
<Id>'s rows are removed from the tracking catalog, so a later ARP entry with the same product code is no longer correlated to <Id>.
Actual behavior
Successfully uninstalled (exit code 0). The log shows the uninstall string ran, and the ARP entry is gone. All of <Id>'s rows are still in installed.db, which the uninstall did not write to. When another product later creates an ARP entry with the same key name, winget list --id <Id> --exact again shows it as <Id> with an upgrade available.
I have only verified this case. Reading the code, any uninstall where the installed version was correlated through the tracking catalog would leave its rows behind.
Environment
Windows Package Manager v1.29.380
Windows: Windows.Desktop v10.0.26300.9818
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.29.380.0
- Vorherrschende Sprache
- C++
- Sterne
- 26.6k
- Forks
- 1.8k
- Ø Merge
- 3 T. 10 Std.
- Gemergte PRs (30 T.)
- 41
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus microsoft/winget-cli
-
Issue-Docs Needs-Triage
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 70/100
microsoft/winget-cli#6692 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
Issue-Docs Possible-Duplicate
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
microsoft/winget-cli#6493 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 2 Tagen
-
Issue-Feature
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
microsoft/winget-cli#6427 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
Issue-Docs msstore
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 64/100
microsoft/winget-cli#6331 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 2 Tagen
-
Command-Source Issue-Bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
microsoft/winget-cli#6148 ·
Maintainer antworten meist innerhalb von 2 Tagen
Alle Issues in microsoft/winget-cli
Ähnliche Issues
-
feat
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 65/100
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
stratum-mining/sv2-tp#167 ·
Maintainer antworten meist innerhalb von 1 Tag
-
better error message bug low priority semantics strings
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
Maintainer antworten meist innerhalb von 1 Tag
-
Sign up button opens the Sign in page instead of the Sign up page for Enterprise edition serversOffenauth bug ui/ux
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
MerginMaps/mobile#4795 ·
Maintainer antworten meist innerhalb von 2 Tagen