winget uninstall leaves tracking catalog rows when the package was correlated through the tracking catalog
I maintainer di solito rispondono entro 2 giorni
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 69/100
Direzione di ricerca
Start with RecordUninstall in src/AppInstallerCLICore/Workflows/UninstallFlow.cpp and trace how the correlated installed version’s ID and source are passed to PackageTrackingCatalog::RecordUninstall in src/AppInstallerRepositoryCore/PackageTrackingCatalog.cpp. Read the linked CompositeSource.cpp methods to understand the ID/source behavior, then find or add coverage for the tracking-correlated uninstall case. Done when uninstall removes the package’s rows from installed.db, preventing later ARP entries with the same product code from being correlated to it.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Relevant area(s)
WinGet CLI
Relevant command(s)
winget uninstall
Brief description of your issue
When the installed (ARP) entry was correlated to the available package through the source's tracking catalog, winget uninstall reports success but leaves that package's rows in the tracking catalog (installed.db). Any later ARP entry with the same product code is then correlated to the old package again.
From the source (v1.29.380; the same code is on master today):
RecordUninstallseedsUninstallCorrelatedSourceswithGetInstalledVersion(package)first (UninstallFlow.cpp#L442-L463).- For a tracking-correlated package, that installed version is a
CompositeInstalledVersion. ItsGetSource()returns the tracking (remote) source (CompositeSource.cpp#L313-L322), but itsGetProperty(Id)returns the base installed version's id, i.e. the ARP-derived id such asARP\User\X64\<Key>(CompositeSource.cpp#L292-L301). - So the first item is {ARP-derived id, winget source}. The available package from that same source is then skipped by the same-source check (UninstallFlow.cpp#L39-L61), and
PackageTrackingCatalog::RecordUninstalllooks up the ARP-derived id, matches nothing and removes nothing (PackageTrackingCatalog.cpp#L292-L309).
Steps to reproduce
- Start with tracking-catalog rows for a package
<Id>(sourcewinget) whose recorded product codes include a plain ARP key name<Key>, and no ARP entry named<Key>. Seen withqup1010.FilePilot: its rows for 1.0.5 and 1.0.7 record product codefilepilot(from the ProductCode collision in microsoft/winget-pkgs#448131). - Create a per-user ARP entry
HKCU\Software\Microsoft\Windows\CurrentVersion\Uninstall\<Key>withDisplayName,Publisher,DisplayVersion, andUninstallString=QuietUninstallString=cmd /c reg delete "HKCU\Software\Microsoft\Windows\CurrentVersion\Uninstall\<Key>" /f. winget list --id <Id> --exactshows the entry as<Id>.winget uninstall --id <Id> --exact --source winget --silent- Check a copy of
%LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Microsoft.Winget.Source_8wekyb3d8bbwe\installed.dbfor manifest rows of<Id>.
Expected behavior
<Id>'s rows are removed from the tracking catalog, so a later ARP entry with the same product code is no longer correlated to <Id>.
Actual behavior
Successfully uninstalled (exit code 0). The log shows the uninstall string ran, and the ARP entry is gone. All of <Id>'s rows are still in installed.db, which the uninstall did not write to. When another product later creates an ARP entry with the same key name, winget list --id <Id> --exact again shows it as <Id> with an upgrade available.
I have only verified this case. Reading the code, any uninstall where the installed version was correlated through the tracking catalog would leave its rows behind.
Environment
Windows Package Manager v1.29.380
Windows: Windows.Desktop v10.0.26300.9818
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.29.380.0
- Lingua principale
- C++
- Stelle
- 26.6k
- Fork
- 1.8k
- Merge medio
- 3g 10h
- PR unite (30g)
- 41
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di microsoft/winget-cli
-
Issue-Docs Needs-Triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
microsoft/winget-cli#6692 ·
I maintainer di solito rispondono entro 2 giorni
-
Issue-Docs Possible-Duplicate
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
microsoft/winget-cli#6493 · 1 commento ·
I maintainer di solito rispondono entro 2 giorni
-
WinGetSourceCreator: PackWithMappingFile should verify makeappx.exe exists before invoking itApertaIssue-Feature
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
microsoft/winget-cli#6427 ·
I maintainer di solito rispondono entro 2 giorni
-
Issue-Docs msstore
Difficoltà 2/5 1-3 ore Idoneità per principianti 64/100
microsoft/winget-cli#6331 · 1 commento ·
I maintainer di solito rispondono entro 2 giorni
-
Command-Source Issue-Bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
microsoft/winget-cli#6148 ·
I maintainer di solito rispondono entro 2 giorni
Tutte le issue di microsoft/winget-cli
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
stratum-mining/sv2-tp#167 ·
I maintainer di solito rispondono entro 1 giorno
-
Sign up button opens the Sign in page instead of the Sign up page for Enterprise edition serversApertaauth bug ui/ux
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
MerginMaps/mobile#4795 ·
I maintainer di solito rispondono entro 2 giorni
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
HarperFast/rocksdb-js#1118 ·
I maintainer di solito rispondono entro 1 giorno
-
bug triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
I maintainer di solito rispondono entro 1 giorno
-
26.04 bug dark-mode Easy Hack impress symptom: visual
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
CollaboraOnline/online#16421 · 1 commento ·