Add AdGuard local DNS rewrite tools (list, add, delete)
維護者通常 1 天內回覆
評估
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 新手友好度
- 72/100
- Issue 類型
- 功能
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- typescript
- 領域
- networking, tooling
研究方向
Start by reading mcp-server/src/tools/adguardFilterToggle.ts to see how an AdGuard POST is authenticated and wrapped in a confirm gate, then find where tools are registered so the two new ones follow the same shape. Check whether an AdGuard request/response type module already exists before adding new ones, and mirror the existing tool tests under mcp-server (npm test, npm run typecheck). Finish by adding both tools to skills/dns-management/SKILL.md around the cited lines. Done means list returns rewrites, set validates domain/answer and requires confirmation, and the skill documents both.
由索引模型根據 Issue 內容生成。
描述
Summary
The dns-management skill covers creating local DNS rewrites and cites POST /control/rewrite/add, but no tool lists or changes rewrites.
Where
skills/dns-management/SKILL.md:4, :25, :52, :79mcp-server/src/tools/adguardFilterToggle.ts(existing authenticated, confirm-gated AdGuard POST)
Details
service.home.lab -> Pi IP is the most common home-lab DNS task. Today it needs a hand edit or a free-form nodeExec curl.
Impact
The skill's main workflow has no safe tool path.
Suggested fix
Add read-only homelab_adguardRewrites (GET /control/rewrite/list) and confirm-gated homelab_adguardRewriteSet (action: add|delete, domain, answer validated as IP or hostname), reusing the AdGuard auth helper and the filter-toggle request pattern. Add both to the skill.
Acceptance criteria
- List and set tools registered with correct annotations
- Set tool confirm-gated with input validation
- Skill updated
Getting started
- Relevant files:
mcp-server/src/tools/adguardFilterToggle.ts,skills/dns-management/SKILL.md - How to run tests:
cd mcp-server && npm install && npm test(andnpm run typecheck); structure tests:pip install -r requirements-test.txt && pytest tests/ -v - Conventions: see
CLAUDE.mdandCONTRIBUTING.md
Filed by repo-audit/full-audit at 636fefb. Severity: medium. Effort: S. audit-key: enhancement|skills/dns-management/SKILL.md|homelab_adguardRewrites
- 主要語言
- TypeScript
- 星號
- 0
- 分支
- 4
- 平均合併
- 10 小時 16 分鐘
- 30 天內合併 PR
- 2
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
TMHSDigital/Home-Lab-Developer-Tools 的其他 Issue
-
speedtestResults ignores count: /api/speedtest/latest returns one result可能已有人在做 @laozhej 於 2 天前認領。 未關閉bug severity: low
難度 2/5 1-3 小時 新手友好度 80/100
TMHSDigital/Home-Lab-Developer-Tools#160 ·
維護者通常 1 天內回覆
-
Integration tests import tool modules inside tests and can time out under load可能已有人在做 @laozhej 於 2 天前認領。 未關閉good first issue severity: low testing
難度 2/5 1-3 小時 新手友好度 25/100
TMHSDigital/Home-Lab-Developer-Tools#174 ·
維護者通常 1 天內回覆
-
Grafana dashboard import to complete the export/import round trip可能已有人在做 @laozhej 今天認領。 未關閉enhancement severity: low
難度 3/5 1-2 天 新手友好度 68/100
TMHSDigital/Home-Lab-Developer-Tools#171 ·
維護者通常 1 天內回覆
-
help wanted severity: low testing
難度 4/5 3-5 天 新手友好度 55/100
TMHSDigital/Home-Lab-Developer-Tools#164 · 1 則留言 ·
維護者通常 1 天內回覆
-
enhancement severity: medium
難度 3/5 1-2 天 新手友好度 72/100
TMHSDigital/Home-Lab-Developer-Tools#159 ·
維護者通常 1 天內回覆
查看 TMHSDigital/Home-Lab-Developer-Tools 的全部 Issue
相似的 Issue
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)未關閉
難度 2/5 1-3 小時 新手友好度 62/100
microsoft/playwright#44289 ·
維護者通常 1 天內回覆
-
good first issue
難度 2/5 半天 新手友好度 65/100
維護者通常 1 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 72/100
blamechris/chroxy#9272 ·
維護者通常 1 天內回覆
-
no-repo-link tool-submission
難度 1/5 1 小時以內 新手友好度 66/100
BraveOPotato/NoSignups#2458 ·
-
難度 2/5 1-3 小時 新手友好度 70/100
drmrd/vernacular#1061 ·
維護者通常 1 天內回覆