Add AdGuard local DNS rewrite tools (list, add, delete)

未關閉
#157 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

@laozhej 已經在處理了。

開始於 2026年11月20日。

  • #177 來自 @laozhej —— 未關閉

評估

難度
3/5
預估耗時
1-2 天
新手友好度
72/100
Issue 類型
功能
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
typescript

研究方向

Start by reading mcp-server/src/tools/adguardFilterToggle.ts to see how an AdGuard POST is authenticated and wrapped in a confirm gate, then find where tools are registered so the two new ones follow the same shape. Check whether an AdGuard request/response type module already exists before adding new ones, and mirror the existing tool tests under mcp-server (npm test, npm run typecheck). Finish by adding both tools to skills/dns-management/SKILL.md around the cited lines. Done means list returns rewrites, set validates domain/answer and requires confirmation, and the skill documents both.

由索引模型根據 Issue 內容生成。

描述

enhancement severity: medium

Summary

The dns-management skill covers creating local DNS rewrites and cites POST /control/rewrite/add, but no tool lists or changes rewrites.

Where

  • skills/dns-management/SKILL.md:4, :25, :52, :79
  • mcp-server/src/tools/adguardFilterToggle.ts (existing authenticated, confirm-gated AdGuard POST)

Details

service.home.lab -> Pi IP is the most common home-lab DNS task. Today it needs a hand edit or a free-form nodeExec curl.

Impact

The skill's main workflow has no safe tool path.

Suggested fix

Add read-only homelab_adguardRewrites (GET /control/rewrite/list) and confirm-gated homelab_adguardRewriteSet (action: add|delete, domain, answer validated as IP or hostname), reusing the AdGuard auth helper and the filter-toggle request pattern. Add both to the skill.

Acceptance criteria

  • List and set tools registered with correct annotations
  • Set tool confirm-gated with input validation
  • Skill updated

Getting started

  • Relevant files: mcp-server/src/tools/adguardFilterToggle.ts, skills/dns-management/SKILL.md
  • How to run tests: cd mcp-server && npm install && npm test (and npm run typecheck); structure tests: pip install -r requirements-test.txt && pytest tests/ -v
  • Conventions: see CLAUDE.md and CONTRIBUTING.md

Filed by repo-audit/full-audit at 636fefb. Severity: medium. Effort: S. audit-key: enhancement|skills/dns-management/SKILL.md|homelab_adguardRewrites

主要語言
TypeScript
星號
0
分支
4
平均合併
10 小時 16 分鐘
30 天內合併 PR
2

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

TMHSDigital/Home-Lab-Developer-Tools 的其他 Issue

查看 TMHSDigital/Home-Lab-Developer-Tools 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。