ENH: Review connected-component buffer size guarantees
维护者通常 6 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 32/100
- Issue 类型
- 功能
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- cpp
- 领域
- backend, performance
调研方向
Start by reading ConnectedComponentEngine and the linked simplnx #1764 change, then trace its 2D row, tile, replay and finalization buffers, 3D plane and grouped-transfer buffers, and ScratchBuffer<T> callers. The issue asks for agreement on exact allocation guarantees, growing run and label data, fallback behavior, and test ownership before choosing an implementation. Done means a reviewed plan covering representative 2D/3D cases, both storage modes, actual disk-backed storage, runtime and memory, and preserved output, error, and cancellation behavior.
由索引模型根据 Issue 内容生成。
描述
Summary
Review the data-sized working buffers in ConnectedComponentEngine and establish which buffers need exact element-count allocation under the agreed data-payload accounting rule. This work is deferred from simplnx #1764 to a separate branch. The intended scope, including dynamically growing run and label state, needs agreement before implementation.
Mike's review note includes algorithm working arrays in data payload and names the connected-component engine. The engine uses existing std::vector buffers in its 2D and 3D paths. In the 2D path, the planner counts a requested number of run elements, while std::vector::reserve only promises a capacity of at least that number. The 2D value is a planning target; it is not itself a working-memory reservation. The 3D path also uses vectors for some buffers associated with working reservations.
These vectors existed before the accounting change in #1764. This observation does not establish that a supported standard library has allocated extra capacity or that a user has encountered a memory overrun. Normal allocator overhead is outside the payload accounting rule, and the rule does not cap the whole process.
Inspect the 2D row, tile, replay and finalization buffers and the 3D plane and grouped-transfer buffers. Decide separately how the rule applies to growing run, union-find and label data and to the existing low-memory fallback. The generic ScratchBuffer<T> currently uses std::vector for non-bool types, so its name alone does not establish an exact-capacity guarantee. Avoid changing it globally without reviewing its other callers.
The engine serves the Connected Component Image Filter, Threshold Maximum Connected Components Image Filter, and Morphological Watershed Image Filter. It runs with in-memory as well as out-of-core stores. Preserve output, error and cancellation behavior; check runtime and memory in both storage modes. Use independent small label/count expectations, representative 2D and 3D cases, tight and sufficient allowances, and tests that witness actual disk-backed storage. Verify which engine path each test reaches. Review proposed buffer ownership and test strategy before selecting an implementation.
- 主要语言
- C++
- 星标
- 18
- 派生
- 15
- 平均合并
- 4 天 23 小时
- 30 天内合并 PR
- 42
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
BlueQuartzSoftware/simplnx 的其他 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
BlueQuartzSoftware/simplnx#1987 ·
维护者通常 6 天内回复
-
documentation
难度 2/5 1-3 小时 新手友好度 74/100
BlueQuartzSoftware/simplnx#1980 ·
维护者通常 6 天内回复
-
Testing
难度 2/5 1-3 小时 新手友好度 62/100
BlueQuartzSoftware/simplnx#1979 ·
维护者通常 6 天内回复
-
documentation
难度 2/5 1-3 小时 新手友好度 65/100
BlueQuartzSoftware/simplnx#1978 ·
维护者通常 6 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
BlueQuartzSoftware/simplnx#1945 ·
维护者通常 6 天内回复
查看 BlueQuartzSoftware/simplnx 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
HarperFast/rocksdb-js#1118 ·
维护者通常 1 天内回复
-
bug triage
难度 2/5 1-3 小时 新手友好度 75/100
维护者通常 1 天内回复
-
26.04 bug dark-mode Easy Hack impress symptom: visual
难度 2/5 1-3 小时 新手友好度 68/100
CollaboraOnline/online#16421 · 1 条评论 ·
-
enhancement
难度 2/5 1-3 小时 新手友好度 63/100
telegramdesktop/tdesktop#31653 ·
维护者通常 1 天内回复
-
area/cs bug
难度 2/5 1-3 小时 新手友好度 82/100
ydb-platform/ydb#59881 · 1 条评论 ·
维护者通常 1 天内回复