ENH: Review connected-component buffer size guarantees

オープン
#1,928 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 6 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
32/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
活発
技術スタック
cpp

調査の方向性

Start by reading ConnectedComponentEngine and the linked simplnx #1764 change, then trace its 2D row, tile, replay and finalization buffers, 3D plane and grouped-transfer buffers, and ScratchBuffer<T> callers. The issue asks for agreement on exact allocation guarantees, growing run and label data, fallback behavior, and test ownership before choosing an implementation. Done means a reviewed plan covering representative 2D/3D cases, both storage modes, actual disk-backed storage, runtime and memory, and preserved output, error, and cancellation behavior.

索引モデルが issue の本文から書いたものです。

説明

enhancement Out-of-Core

Summary

Review the data-sized working buffers in ConnectedComponentEngine and establish which buffers need exact element-count allocation under the agreed data-payload accounting rule. This work is deferred from simplnx #1764 to a separate branch. The intended scope, including dynamically growing run and label state, needs agreement before implementation.

Mike's review note includes algorithm working arrays in data payload and names the connected-component engine. The engine uses existing std::vector buffers in its 2D and 3D paths. In the 2D path, the planner counts a requested number of run elements, while std::vector::reserve only promises a capacity of at least that number. The 2D value is a planning target; it is not itself a working-memory reservation. The 3D path also uses vectors for some buffers associated with working reservations.

These vectors existed before the accounting change in #1764. This observation does not establish that a supported standard library has allocated extra capacity or that a user has encountered a memory overrun. Normal allocator overhead is outside the payload accounting rule, and the rule does not cap the whole process.

Inspect the 2D row, tile, replay and finalization buffers and the 3D plane and grouped-transfer buffers. Decide separately how the rule applies to growing run, union-find and label data and to the existing low-memory fallback. The generic ScratchBuffer<T> currently uses std::vector for non-bool types, so its name alone does not establish an exact-capacity guarantee. Avoid changing it globally without reviewing its other callers.

The engine serves the Connected Component Image Filter, Threshold Maximum Connected Components Image Filter, and Morphological Watershed Image Filter. It runs with in-memory as well as out-of-core stores. Preserve output, error and cancellation behavior; check runtime and memory in both storage modes. Use independent small label/count expectations, representative 2D and 3D cases, tight and sufficient allowances, and tests that witness actual disk-backed storage. Verify which engine path each test reaches. Review proposed buffer ownership and test strategy before selecting an implementation.

主要言語
C++
スター
18
フォーク
15
平均マージ
4日 23時間
マージ済み PR(30日)
42

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

BlueQuartzSoftware/simplnx のほかの issue

BlueQuartzSoftware/simplnx の issue をすべて見る

似ている issue

C++ の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。