TEST: Run the Align Sections example pipelines as pipeline tests

未关闭 适合新手
#1,979 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 6 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
62/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
cmake, cpp
领域
testing-qa

调研方向

从 src/Plugins/SimplnxCore/test/CMakeLists.txt 中的 PREBUILT_PIPELINE_NAMES 列表(第 386-411 行)开始,查看 create_pipeline_tests() 如何注册每个条目。将 src/Plugins/SimplnxCore/pipelines/Align_Sections_Examples/ 中的三个 Align_Sections 流水线添加到该列表,并检查是否为它们获取了输入归档 Data/。当 ctest 运行全部三个对齐流水线测试且全部通过时,即完成。

由索引模型根据 Issue 内容生成。

描述

Testing

Summary

The three example pipelines in src/Plugins/SimplnxCore/pipelines/Align_Sections_Examples/ are not run by any test. A change that breaks them is found only by running them by hand.

How it works now. create_pipeline_tests() turns each pipeline in a plugin's PREBUILT_PIPELINE_NAMES list into a ctest entry. The SimplnxCore list (test/CMakeLists.txt lines 386-411) has 9 of the 41 SimplnxCore example pipelines. None of the three alignment pipelines is listed:

  • Align_Sections_Backwards_Compatibility.d3dpipeline
  • Align_Sections_No_File.d3dpipeline
  • Align_Sections_User_Input.d3dpipeline

Why it is needed. #1908 item L78 was a defect in exactly this path: the backwards-compatibility pipeline read a legacy shift file that was missing its first row, and no test noticed. The batch 4 fix updates the pipelines and the input archive (align_sections_input_v2.tar.gz), but they are still checked only by hand.

Where it applies. The three pipelines above and the SimplnxCore PREBUILT_PIPELINE_NAMES list. They read their inputs from the Data/ folder, so the tests need the input archive to be downloaded. Whether the other unlisted SimplnxCore example pipelines should be registered in the same change is still open.

Found during the review of the #1908 batch 4 changes. No open issue covered it.

主要语言
C++
星标
18
派生
15
平均合并
4 天 23 小时
30 天内合并 PR
42

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

BlueQuartzSoftware/simplnx 的其他 Issue

查看 BlueQuartzSoftware/simplnx 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。