ENH: Review connected-component buffer size guarantees
I maintainer di solito rispondono entro 6 giorni
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 32/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Attiva
- Stack tecnologico
- cpp
- Ambito
- backend, performance
Direzione di ricerca
Start by reading ConnectedComponentEngine and the linked simplnx #1764 change, then trace its 2D row, tile, replay and finalization buffers, 3D plane and grouped-transfer buffers, and ScratchBuffer<T> callers. The issue asks for agreement on exact allocation guarantees, growing run and label data, fallback behavior, and test ownership before choosing an implementation. Done means a reviewed plan covering representative 2D/3D cases, both storage modes, actual disk-backed storage, runtime and memory, and preserved output, error, and cancellation behavior.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
Review the data-sized working buffers in ConnectedComponentEngine and establish which buffers need exact element-count allocation under the agreed data-payload accounting rule. This work is deferred from simplnx #1764 to a separate branch. The intended scope, including dynamically growing run and label state, needs agreement before implementation.
Mike's review note includes algorithm working arrays in data payload and names the connected-component engine. The engine uses existing std::vector buffers in its 2D and 3D paths. In the 2D path, the planner counts a requested number of run elements, while std::vector::reserve only promises a capacity of at least that number. The 2D value is a planning target; it is not itself a working-memory reservation. The 3D path also uses vectors for some buffers associated with working reservations.
These vectors existed before the accounting change in #1764. This observation does not establish that a supported standard library has allocated extra capacity or that a user has encountered a memory overrun. Normal allocator overhead is outside the payload accounting rule, and the rule does not cap the whole process.
Inspect the 2D row, tile, replay and finalization buffers and the 3D plane and grouped-transfer buffers. Decide separately how the rule applies to growing run, union-find and label data and to the existing low-memory fallback. The generic ScratchBuffer<T> currently uses std::vector for non-bool types, so its name alone does not establish an exact-capacity guarantee. Avoid changing it globally without reviewing its other callers.
The engine serves the Connected Component Image Filter, Threshold Maximum Connected Components Image Filter, and Morphological Watershed Image Filter. It runs with in-memory as well as out-of-core stores. Preserve output, error and cancellation behavior; check runtime and memory in both storage modes. Use independent small label/count expectations, representative 2D and 3D cases, tight and sufficient allowances, and tests that witness actual disk-backed storage. Verify which engine path each test reaches. Review proposed buffer ownership and test strategy before selecting an implementation.
- Lingua principale
- C++
- Stelle
- 18
- Fork
- 15
- Merge medio
- 4g 23h
- PR unite (30g)
- 42
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di BlueQuartzSoftware/simplnx
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
BlueQuartzSoftware/simplnx#1987 ·
I maintainer di solito rispondono entro 6 giorni
-
documentation
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
BlueQuartzSoftware/simplnx#1980 ·
I maintainer di solito rispondono entro 6 giorni
-
Testing
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
BlueQuartzSoftware/simplnx#1979 ·
I maintainer di solito rispondono entro 6 giorni
-
documentation
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
BlueQuartzSoftware/simplnx#1978 ·
I maintainer di solito rispondono entro 6 giorni
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
BlueQuartzSoftware/simplnx#1945 ·
I maintainer di solito rispondono entro 6 giorni
Tutte le issue di BlueQuartzSoftware/simplnx
Issue simili
-
bug triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
I maintainer di solito rispondono entro 1 giorno
-
26.04 bug dark-mode Easy Hack impress symptom: visual
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
CollaboraOnline/online#16421 · 1 commento ·
-
area/cs bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
ydb-platform/ydb#59881 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 64/100
I maintainer di solito rispondono entro 1 giorno
-
documentation enhancement lua server
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100